Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserved data and added database #34

Merged
merged 9 commits into from
Jan 11, 2023
Merged

Preserved data and added database #34

merged 9 commits into from
Jan 11, 2023

Conversation

NahnahAJ
Copy link
Owner

Project Requirements

  • All data are preserved by saving collections in .json files.
  • Created a schema.sql file with tables that will be analogical to the structure of the classes created:
  • games table (add all properties and associations from the parent Item class as table columns)
  • and the authors table

@NahnahAJ NahnahAJ linked an issue Jan 11, 2023 that may be closed by this pull request
Copy link
Collaborator

@NatanimA NatanimA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @NahnahAJ

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Highlights

  • Descriptive PR✔️
  • Preserved dada ✔️
  • Inserted queries in schema ✔️

@NahnahAJ NahnahAJ merged commit bbfed8b into dev Jan 11, 2023
@NahnahAJ NahnahAJ linked an issue Jan 11, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[2pts] Create schma.sql file with tables [1pt] Preserve data
2 participants