Added popup window #9
Conversation
There was a problem hiding this comment.
Hi @NahnahAJ,
Good job so far 👍🏼
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
✔️ No linter errors
✔️ Used GitHub Flow
✔️ Work documented professionally
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
| @@ -424,5 +424,6 @@ <h4 class="desktop-header">Get started</h4> | |||
| </div> | |||
| </footer> | |||
| <script src="menu.js"></script> | |||
| <script src="popup.js"></script> | |||
There was a problem hiding this comment.
- The projects section should be created dynamically using JavaScript, kindly consider removing the project section from your HTML file from around line
100to line289, and generate this section (Project section) dynamically on your script file
| @@ -424,5 +424,6 @@ <h4 class="desktop-header">Get started</h4> | |||
| </div> | |||
| </footer> | |||
| <script src="menu.js"></script> | |||
| <script src="popup.js"></script> | |||
There was a problem hiding this comment.
- The mobile popup on the mobile view has more space between the buttons and the paragraph, kindly consider fixing this so your design looks more professional and fits all screen sizes properly
There was a problem hiding this comment.
Hi @NahnahAJ,
Your project is complete! There is nothing else to say other than... it's time to merge it 
Congratulations! 🎉
Highlights
- No linter errors. ✔️
- GitHub flow is followed. ✔️
- Professional README file. ✔️
- PR has a good title and summary. ✔️
Optional suggestions
Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
In This Branch