To Do list: list structure #1
Conversation
There was a problem hiding this comment.
Hi @NahnahAJ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!
Highlights
- No linter errors. ✔️
- GitHub flow is followed. ✔️
- PR has a good title and summary. ✔️
Required Changes ♻️
Check the comments under the review.
Optional suggestions
Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.
Cheers and Happy coding!👏👏👏
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
modules/objects.js
Outdated
| { | ||
| string: 'Complete to do list project', | ||
| boo1: 'Join stand-up Call', | ||
| id: '1', | ||
| }, | ||
| { | ||
| string: 'Join stand-up Call', | ||
| boo1: 'Not completed', | ||
| id: '2', | ||
| }, | ||
| { | ||
| string: 'Arange a call', | ||
| boo1: 'Join stand-up Call', | ||
| id: '3', | ||
| }, | ||
| { | ||
| string: 'Control the teams project', | ||
| boo1: 'Join stand-up Call', | ||
| id: '4', | ||
| }, | ||
| ]; |
There was a problem hiding this comment.
- According to the requirement, you need to set an array of some simple to-do tasks (array of objects). Each task object should contain three keys. that is:
description [string], completed [bool], index: [number]. Please make it like this.
const tasks = [ { description: 'An example description in string', completed: false, index: 10, }, ];
modules/populateFunction.js
Outdated
| <div class="container"> | ||
| <span><input type='checkbox'>${element.string}</span> | ||
| <div><i class="fa-solid fa-ellipsis-vertical"></i></div> | ||
| </div><hr> |
There was a problem hiding this comment.
- I would suggest you please make sure to populate the HTML list item element for each task. You have populated the string but make sure to populate the
completed [bool]. For reference:
<p>${completed ? 'completed' : 'not completed'}</p>`;
README.md
Outdated
|
|
||
| To get a local copy up and running follow these simple example steps. | ||
|
|
||
| ### Prerequisites | ||
|
|
||
| - Have a Desktop or Laptop Computer running on with Windows, Mac OS or Linux operating system. | ||
| - Have git installed on the Computer | ||
| - Have a browser install on the Computer | ||
|
|
||
| ### Setup | ||
|
|
||
| - If it suits you, on your local computer, create a directory in your preferred location (e.g in the Desktop or Document directory) | ||
|
|
||
| ### Install | ||
|
|
||
| - Open your Terminal/Powershell or any command line interface you use, then navigate to your created above directory or the directory you'll like to clone this project directory. | ||
| - Type `https://github.com/NahnahAJ/To-Do-List.git` if your're using https with git or `git@github.com:NahnahAJ/To-Do-List.git` if your preferred is ssh and hit enter. | ||
| - Navigate to the `To-Do List` directory on your local computer in your above chosen directory and open the `src/index.html` file. |
There was a problem hiding this comment.
- I would suggest you please make sure that you write the proper step to run the project on the machine.
For example, You need to donpm installthen only you have to donpm startto start the project. please write those step
There was a problem hiding this comment.
Status: Approved ✔️
Hi @NahnahAJ
Your project is complete! Great job for making the requested changes🥇. There is nothing else to say other than... it's time to merge it 🍾🚢 
. Congratulations! 🎉💯🌟
Good Points 👍
- Descriptive Pull Request
- No linter errors
Cheers..Happy coding!..and keep soaring higher! 💻 🍷 🚀
Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have 2 more limited reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.
Project Requirements
Set up a new project with webpack that is based on the webpack exercise you have already completed.
Create an
index.html file and write your HTML markup here. Create an empty To Do List placeholder(<div> or <ul> element). Theindex.htmlfile must be set as a template using the HTML Webpack Plugin.Create an
index.jsfile and set an array of some simple to do tasks (array of objects). Each task object should contain three keys:Write a function to iterate over the tasks array and populate an HTML list item element for each task.
On page load render the dynamically created list of tasks in the dedicated placeholder. The list should appear in order of the index values for each task.
Create a style.css and set rules for the To Do List. CSS must be loaded by Webpack Style/CSS Loader. Your list should be a clone of the part of the minimalist project captured in the video below.
All your source files
(index.html, index.js and style.css)must be located in /src directory and your distribution files will be generated by webpack and served by webpack dev server from /dist folder.