Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do list: interactive list #3

Merged
merged 7 commits into from
Oct 1, 2022
Merged

To Do list: interactive list #3

merged 7 commits into from
Oct 1, 2022

Conversation

NahnahAJ
Copy link
Owner

@NahnahAJ NahnahAJ commented Oct 1, 2022

Project requirements

  • Add a new JavaScript file and import it as a module:
  • it will contain methods related to the status updates (completed: true / false).
  • Add event listener to the checkbox (change).
  • Update items object's value for completed key upon user actions.
  • Implement a function for the "Clear all completed" button (use filter() method).
  • Store the updated array of items in local storage, so the user gets the correct list values after the page reloads.

Copy link

@prolajumokeoni prolajumokeoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NahnahAJ,
Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Highlights

✔️ No linter errors
✔️ Git flow was correctly used
✔️ Good PR title and Description

Required Changes ♻️

  • Please ensure that your app is functioning properly, I cannot add a new todo, Kindly work on this feature of the application as it is needed to test the app properly, see project requirements and video below ⬇️
Loom.Message.-.1.October.2022.mp4

Check the comments under the review.

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

You can also consider:

  • N/A
    Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@github-pages github-pages bot temporarily deployed to github-pages October 1, 2022 19:58 Inactive
@NahnahAJ NahnahAJ closed this Oct 1, 2022
@NahnahAJ NahnahAJ reopened this Oct 1, 2022
@NahnahAJ
Copy link
Owner Author

NahnahAJ commented Oct 1, 2022

Hello @prolajumokeoni I checked on your comment but the app works fine on my end I also sent it out to colleagues and they confirmed that it is working. So I am not sure what the problem is. I have attached a loom video link below.

https://www.loom.com/share/348a3a09bfcf4e6583d8286cc4b6bce3

Copy link

@franclobo franclobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NahnahAJ,

Required Changes ♻️

Great work on making the changes requested by a previous reviewer 👏
You've done well implementing some of the requested changes, but there are still some which aren't addressed yet.

Highlights

  • No linter errors ✔️
  • Correct Github flow ✔️
  • Descriptive PR ✔️
  • Professional README file ✔️
  • Good communication with code reviewer 💯

Required Changes ♻️

Check the comments under the review.

  • I have cloned your repository but I could not add activities to the list 👇🏽.
To-Do.List.-.Google.Chrome.2022-10-01.15-29-11.mp4

As the last code reviewer said:

Please ensure that your app is functioning properly, I cannot add a new todo, Kindly work on this feature of the application as it is needed to test the app properly, see project requirements and video below ⬇️

To-Do.List.-.Google.Chrome.2022-10-01.15-29-11.mp4

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@github-pages github-pages bot temporarily deployed to github-pages October 1, 2022 20:44 Inactive
@github-pages github-pages bot temporarily deployed to github-pages October 1, 2022 20:49 Inactive
@github-pages github-pages bot temporarily deployed to github-pages October 1, 2022 22:11 Inactive
Copy link

@mgmediaweb mgmediaweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @NahnahAJ,

Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

approved5

Highlights 💯

  • Good job following the advice of the previous reviewer ✔️

Optional suggestions

Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@NahnahAJ NahnahAJ merged commit d1f58ca into main Oct 1, 2022
@NahnahAJ NahnahAJ deleted the interactivity branch October 1, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants