Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automate deployment and running of naisdevice-health-checker #152

Merged
merged 4 commits into from
Nov 10, 2020
Merged

Automate deployment and running of naisdevice-health-checker #152

merged 4 commits into from
Nov 10, 2020

Conversation

christeredvartsen
Copy link
Member

@christeredvartsen christeredvartsen commented Nov 9, 2020 •
edited
Loading

We need to do the following:

@christeredvartsen christeredvartsen added the enhancement New feature or request label Nov 9, 2020
@christeredvartsen christeredvartsen self-assigned this Nov 9, 2020
@christeredvartsen christeredvartsen marked this pull request as ready for review November 9, 2020 15:44
sechmann
sechmann requested changes Nov 9, 2020
View reviewed changes
Copy link
Contributor

@sechmann sechmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed my mind, needs changes
also add newlines to end of both files

ansible/roles/apiserver/templates/naisdevice-health-checker.service.j2 Show resolved Hide resolved
@christeredvartsen christeredvartsen force-pushed the feature/deploy-and-run-naisdevice-health-checker branch from b85a867 to 2373d31 Compare November 9, 2020 16:02
@christeredvartsen
Copy link
Member Author

also add newlines to end of both files

Fixed in abc3f49

@christeredvartsen christeredvartsen merged commit fee12d6 into master Nov 10, 2020
@christeredvartsen christeredvartsen deleted the feature/deploy-and-run-naisdevice-health-checker branch November 10, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sechmann sechmann sechmann approved these changes

Assignees

@christeredvartsen christeredvartsen

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christeredvartsen @sechmann