Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers persist through multiple requests #50

Closed
DrewCarlson opened this issue Dec 9, 2016 · 2 comments · Fixed by #58
Closed

Headers persist through multiple requests #50

DrewCarlson opened this issue Dec 9, 2016 · 2 comments · Fixed by #58

Comments

@DrewCarlson
Copy link

The headers passed in via options is improperly being merged into defaults causing headers from a previous request to be reused.

See https://github.com/DrewCarlson/najax/tree/header-disposal for a failing test.
@DrewCarlson DrewCarlson mentioned this issue Dec 10, 2016
Closed
@alanclarke
Copy link
Contributor

#54

@Turbo87
Copy link
Contributor

Turbo87 commented Jan 30, 2017 •
edited
Loading

@alanclarke this is unfortunately still broken in v1.0.0. to reproduce you can rebase https://github.com/DrewCarlson/najax/tree/header-disposal onto the current master

@Turbo87 Turbo87 mentioned this issue Jan 30, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix persistent headers bug Turbo87/najax
3 participants
@Turbo87 @alanclarke @DrewCarlson