Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix icon: replace bitcoin.png with namecoin.png #302

Closed
wants to merge 1 commit into from

Conversation

mrpeertopeer
Copy link

Issue:

The bitcoin icon is displayed on the request button and in the incoming transactions section:

request

incoming

Changes:

  • Delete bitcoin.png
  • Add namecoin.png
  • Change icon from bitcoin.png to namecoin.png in
    electrum/gui/qt/main_window.py and electrum/gui/qt/request_list.py

* Delete bitcoin.png

* Add namecoin.png

* Change icon from bitcoin.png to namecoin.png

* Change icon from bitcoin.png to namecoin.png
@yanmaani
Copy link

yanmaani commented Feb 8, 2022

I think the reasonable thing to do here would be to keep the name as bitcoin.png but change it to the Namecoin logo; this helps keep our diff against upstream small.

@mrpeertopeer
Copy link
Author

@yanmaani This is a minor change, and it is not the first time such a renaming has occurred. 

See https://github.com/namecoin/electrum-nmc/blob/master/electrum_nmc/electrum/gui/icons/electrum_nmc.png, which must be fixed in accordance with #288.

@yanmaani
Copy link

yanmaani commented Feb 8, 2022

it is not the first time such a renaming has occurred

Link?

@mrpeertopeer
Copy link
Author

I'm closing this. Do not merge it or I sue you for copyright infringement. You cunt.

@yanmaani
Copy link

Actually, by section D.6 of the GitHub Terms of Service, you irrevocably licensed your contribution under the MIT when you made a pull request to this repository. You cannot sue anyone for merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants