Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement "import" on a 'global' level #5

Closed
wants to merge 0 commits into from

Conversation

domob1812
Copy link

This is a rough first implementation of recursive "import" support that simply replaces "import" fields in JSON objects (and does not handle subdomains). It works for d/kraftware.

@JeremyRand
Copy link
Member

Thanks for working on this. Personally I think this should be implemented in the "data" plugin, not the domain namespace. Maybe as a "getValueProcessed" method, which all other namespaces would call instead of getValue. That way, the same code works verbatim for all namespaces, e.g. id/. How difficult would that be?

@domob1812
Copy link
Author

No problem, I can try to rework it that way! I actually prefer to share it myself, since I believe that "import" should be done via a general spec that can be used for multiple specific namespaces (as you suggest). That's why I also added a "TODO" question in a comment.

Since I'm no expert with the nmcontrol code (and it isn't actually easy to comprehend how the things interact there), I decided to give it a first try as easy as possible before looking for a better place (and to gauge interest). Thanks for your reply, I think I now know better where to look ... I'll give it a try and submit an update in time (hopefully).

@domob1812
Copy link
Author

Closing for now, will implement it in the data plugin instead.

@domob1812 domob1812 closed this Feb 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants