Fix tests to get them pass on AArch64 #4
Conversation
| @@ -405,8 +405,8 @@ BOOST_AUTO_TEST_CASE(Compare) | |||
| { | |||
| BOOST_CHECK_EQUAL( 0, Name("/A") .compare(Name("/A"))); | |||
| BOOST_CHECK_EQUAL( 0, Name("/A") .compare(Name("/A"))); | |||
| BOOST_CHECK_EQUAL(-1, Name("/A") .compare(Name("/B"))); | |||
| BOOST_CHECK_EQUAL( 1, Name("/B") .compare(Name("/A"))); | |||
| BOOST_CHECK_GT(-1, Name("/A") .compare(Name("/B"))); | |||
There was a problem hiding this comment.
hmm are you sure? it should be either _GE(-1, ...) or _GT(0, ...), otherwise it'll break on x86{,_64}
Same thing for the other checks below.
|
Will work on it on Monday. |
|
Those changes worked for me on both AArch64 and x86-64 |
|
ping? |
|
The patch seems incomplete... there are other |
|
Plus, all commits must go through http://gerrit.named-data.net/ |
|
I updated all entries which failed for me on AArch64 and made sure that they do not break x86-64 at same time. Nothing else required changing. And about gerrit... Never used it so submitting patch will take some more time. |
|
And it is hard to find "how to contribute" section on your website. |
|
I created a gerrit change based on your pull request (http://gerrit.named-data.net/#/c/2595/). Should be merged after it passes all tests and any necessary fixes. |
|
Thanks! |
Checked only on AArch64 so far.