Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests to get them pass on AArch64 #4

Closed
wants to merge 3 commits into from
Closed

Fix tests to get them pass on AArch64 #4

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
815f8f0
Fix tests to get them pass on AArch64
hrw Nov 10, 2015
107a9f2
Revert "Fix tests to get them pass on AArch64"
hrw Nov 16, 2015
e9bffa2
Fix test cases to work also on AArch64
hrw Nov 16, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions tests/unit-tests/name.t.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,44 +405,44 @@ BOOST_AUTO_TEST_CASE(Compare)
{
BOOST_CHECK_EQUAL( 0, Name("/A") .compare(Name("/A")));
BOOST_CHECK_EQUAL( 0, Name("/A") .compare(Name("/A")));
BOOST_CHECK_EQUAL(-1, Name("/A") .compare(Name("/B")));
BOOST_CHECK_EQUAL( 1, Name("/B") .compare(Name("/A")));
BOOST_CHECK_GT(-1, Name("/A") .compare(Name("/B")));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm are you sure? it should be either _GE(-1, ...) or _GT(0, ...), otherwise it'll break on x86{,_64}

Same thing for the other checks below.

BOOST_CHECK_LT( 1, Name("/B") .compare(Name("/A")));
BOOST_CHECK_EQUAL(-1, Name("/A") .compare(Name("/AA")));
BOOST_CHECK_EQUAL( 1, Name("/AA") .compare(Name("/A")));
BOOST_CHECK_EQUAL(-1, Name("/A") .compare(Name("/A/C")));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these should be changed too I guess

BOOST_CHECK_EQUAL( 1, Name("/A/C").compare(Name("/A")));

BOOST_CHECK_EQUAL( 0, Name("/Z/A/Y") .compare(1, 1, Name("/A")));
BOOST_CHECK_EQUAL( 0, Name("/Z/A/Y") .compare(1, 1, Name("/A")));
BOOST_CHECK_EQUAL(-1, Name("/Z/A/Y") .compare(1, 1, Name("/B")));
BOOST_CHECK_EQUAL( 1, Name("/Z/B/Y") .compare(1, 1, Name("/A")));
BOOST_CHECK_GT(-1, Name("/Z/A/Y") .compare(1, 1, Name("/B")));
BOOST_CHECK_LT( 1, Name("/Z/B/Y") .compare(1, 1, Name("/A")));
BOOST_CHECK_EQUAL(-1, Name("/Z/A/Y") .compare(1, 1, Name("/AA")));
BOOST_CHECK_EQUAL( 1, Name("/Z/AA/Y") .compare(1, 1, Name("/A")));
BOOST_CHECK_EQUAL(-1, Name("/Z/A/Y") .compare(1, 1, Name("/A/C")));
BOOST_CHECK_EQUAL( 1, Name("/Z/A/C/Y").compare(1, 2, Name("/A")));

BOOST_CHECK_EQUAL( 0, Name("/Z/A") .compare(1, Name::npos, Name("/A")));
BOOST_CHECK_EQUAL( 0, Name("/Z/A") .compare(1, Name::npos, Name("/A")));
BOOST_CHECK_EQUAL(-1, Name("/Z/A") .compare(1, Name::npos, Name("/B")));
BOOST_CHECK_EQUAL( 1, Name("/Z/B") .compare(1, Name::npos, Name("/A")));
BOOST_CHECK_GT(-1, Name("/Z/A") .compare(1, Name::npos, Name("/B")));
BOOST_CHECK_LT( 1, Name("/Z/B") .compare(1, Name::npos, Name("/A")));
BOOST_CHECK_EQUAL(-1, Name("/Z/A") .compare(1, Name::npos, Name("/AA")));
BOOST_CHECK_EQUAL( 1, Name("/Z/AA") .compare(1, Name::npos, Name("/A")));
BOOST_CHECK_EQUAL(-1, Name("/Z/A") .compare(1, Name::npos, Name("/A/C")));
BOOST_CHECK_EQUAL( 1, Name("/Z/A/C").compare(1, Name::npos, Name("/A")));

BOOST_CHECK_EQUAL( 0, Name("/Z/A/Y") .compare(1, 1, Name("/X/A/W"), 1, 1));
BOOST_CHECK_EQUAL( 0, Name("/Z/A/Y") .compare(1, 1, Name("/X/A/W"), 1, 1));
BOOST_CHECK_EQUAL(-1, Name("/Z/A/Y") .compare(1, 1, Name("/X/B/W"), 1, 1));
BOOST_CHECK_EQUAL( 1, Name("/Z/B/Y") .compare(1, 1, Name("/X/A/W"), 1, 1));
BOOST_CHECK_GT(-1, Name("/Z/A/Y") .compare(1, 1, Name("/X/B/W"), 1, 1));
BOOST_CHECK_LT( 1, Name("/Z/B/Y") .compare(1, 1, Name("/X/A/W"), 1, 1));
BOOST_CHECK_EQUAL(-1, Name("/Z/A/Y") .compare(1, 1, Name("/X/AA/W"), 1, 1));
BOOST_CHECK_EQUAL( 1, Name("/Z/AA/Y") .compare(1, 1, Name("/X/A/W"), 1, 1));
BOOST_CHECK_EQUAL(-1, Name("/Z/A/Y") .compare(1, 1, Name("/X/A/C/W"), 1, 2));
BOOST_CHECK_EQUAL( 1, Name("/Z/A/C/Y").compare(1, 2, Name("/X/A/W"), 1, 1));

BOOST_CHECK_EQUAL( 0, Name("/Z/A/Y") .compare(1, 1, Name("/X/A"), 1));
BOOST_CHECK_EQUAL( 0, Name("/Z/A/Y") .compare(1, 1, Name("/X/A"), 1));
BOOST_CHECK_EQUAL(-1, Name("/Z/A/Y") .compare(1, 1, Name("/X/B"), 1));
BOOST_CHECK_EQUAL( 1, Name("/Z/B/Y") .compare(1, 1, Name("/X/A"), 1));
BOOST_CHECK_GT(-1, Name("/Z/A/Y") .compare(1, 1, Name("/X/B"), 1));
BOOST_CHECK_LT( 1, Name("/Z/B/Y") .compare(1, 1, Name("/X/A"), 1));
BOOST_CHECK_EQUAL(-1, Name("/Z/A/Y") .compare(1, 1, Name("/X/AA"), 1));
BOOST_CHECK_EQUAL( 1, Name("/Z/AA/Y") .compare(1, 1, Name("/X/A"), 1));
BOOST_CHECK_EQUAL(-1, Name("/Z/A/Y") .compare(1, 1, Name("/X/A/C"), 1));
Expand Down