Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing the option name by the case-sensitive letter #54

Closed
iamwonseok opened this issue Jan 10, 2017 · 5 comments
Closed

Confusing the option name by the case-sensitive letter #54

iamwonseok opened this issue Jan 10, 2017 · 5 comments

Comments

@iamwonseok
Copy link
Contributor

I think the option name may confused at the letter 'd' or 'D'.

In case of 'd', it uses to specify the directory name, while 'D' uses to configure a certain level of depth.

As I know, many programmers prefer to use shortcut key for simplicity. However, uftrace provides two features with the same letter, even if they can be distinguished by case-sensitive. It would be confusing to users compared to using different letters.

For example, du command that is widely used in linux to get disk usage, it uses 'd' for level of depth. In addition, most of application uses 'o' letter to specify the directory name for output data.

So, I think uftrace needs to modify the name of option to make it clearer. It would be more familiar with users.

What do you think about?

@namhyung
Copy link
Owner

I thought about it. But the -d/--data option is also used for replay, report, graph and dump. I guess -i/--input is more appropriate in this case, but I'd like to have a single option for both cases.

@iamwonseok
Copy link
Contributor Author

I see. As your mention, I think that '-d/--data' option is suitable for those cases. However, I am still thinking that using different characters give to user more intuitive.

If so, what do you think of changing the depth from 'D' to 'L' or 'l'? L or l means the depth-level.

@namhyung
Copy link
Owner

It'll limit the max number of short options to 26, right? And I don't understand why it needs to avoid same character. Do you want to make the short options case-insensitive? I think 'D' is the base one for depth filter and I somehow managed most of filters to have upper cases. And it'd be bad to change an existing option to have a different meaning.

@iamwonseok
Copy link
Contributor Author

iamwonseok commented Jan 11, 2017

Sure, if short options are used without case-sensitive, the limit is 26. But, that's not what I meant to say. I don't want to make the short options case sensitive. I just asked what you think about changing from D to l or L, if it is possible. Now, I understood what you intention is and I agree with your opinion.

Thank you for your answer. I am sorry to make you confused.

@namhyung
Copy link
Owner

No need to be sorry. I was very glad to hear your opinion. Getting feedback from user is always good. Please keep using uftrace and post issues if you find anything inconvenient or unreasonable (hopefully with patches!). Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants