Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: webui notifications #374

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: webui notifications #374

wants to merge 3 commits into from

Conversation

or2e
Copy link
Collaborator

@or2e or2e commented Jul 26, 2024 •
edited
Loading

Activity logs

  • Clan
    • Created
    • Deleted
  • ClanApplication
    • Created
    • Accepted
    • Declined
  • ClanMember
    • Kicked
    • Leaved
    • RoleEdited
User notifications
  • UserRewarded
    • ToUser
  • CharacterRewarded
    • ToUser
  • ClanApplicationCreated
    • ToUser
    • ToClanOfficers
  • ClanApplicationDeclined
    • ToUser
  • ClanApplicationAccepted
    • ToUser
  • ClanMemberKicked
    • ToExClanMember
  • ClanArmory
    • BorrowItem
      • ToLender
    • RemoveItem
      • ToBorrower
    • ReturnItem
      • ToBorrower
        • force return by clan leader
        • auto return
other
  • clear old user notifications
  • ..
  • ..

@or2e or2e linked an issue Jul 26, 2024 that may be closed by this pull request
WebUi notifications #186
Open
@or2e or2e changed the title 186 webui notifications feat: webui notifications Jul 26, 2024
@or2e or2e mentioned this pull request Jul 29, 2024
Closed
5 tasks
@or2e or2e force-pushed the 186-webui-notifications branch 3 times, most recently from 1c2c257 to 167e299 Compare October 17, 2024 17:15
@or2e or2e marked this pull request as ready for review October 20, 2024 16:38
@or2e or2e self-assigned this Oct 20, 2024
Muparadzi
Muparadzi requested changes Nov 1, 2024
View reviewed changes
Copy link
Collaborator

@Muparadzi Muparadzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems good besides the locale stuff!

src/WebUI/locales/en.yml Outdated Show resolved Hide resolved
@or2e or2e requested a review from Muparadzi November 1, 2024 21:34
Muparadzi
Muparadzi previously approved these changes Nov 3, 2024
View reviewed changes
@or2e or2e requested a review from Muparadzi November 6, 2024 15:05
Muparadzi
Muparadzi previously approved these changes Nov 6, 2024
View reviewed changes
@or2e
user notifications
e6a4260 
fix spec

fix GetLeaderboardQuery

some spec

migration

todo

Revert "todo"

This reverts commit 76b92b1.

remove unused i18n strings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Muparadzi Muparadzi Muparadzi left review comments

@Yeldur Yeldur Awaiting requested review from Yeldur

@Meowkov Meowkov Awaiting requested review from Meowkov

At least 3 approving reviews are required to merge this pull request.

Assignees

@or2e or2e

Labels
area/web-api area/web-ui enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

WebUi notifications
2 participants
@or2e @Muparadzi