Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

phpseclib should be optional #88

Closed
kelunik opened this issue Mar 28, 2016 · 2 comments
Closed

phpseclib should be optional #88

kelunik opened this issue Mar 28, 2016 · 2 comments

Comments

@kelunik
Copy link
Contributor

kelunik commented Mar 28, 2016

As phpseclib is optional, it should just be listed in suggest, not in require. That makes it possible to remove the dependency for projects not using it, e.g. when bundling a minimal phar.
@odino
Copy link
Contributor

odino commented Mar 29, 2016

hey @kelunik, thanks for reporting! Would you mind opening a PR for this?

@kelunik kelunik mentioned this issue Mar 29, 2016
Merged
@kelunik
Copy link
Contributor Author

kelunik commented Mar 30, 2016

Closing as PR is merged.

@kelunik kelunik closed this as completed Mar 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@odino @kelunik