Make ext-openssl and phpseclib optional dependencies #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kelunik looks good. Shallwe go for a major release so that others can upgrade as they want? I guess a bunch of people would want to rely on having those libraries installed, whereas others wouldnt mind at all :) |
|
If you don't have any other breaking changes pending and think this change satisfies a new major version by itself, go ahead. |
|
thanks man! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #88. Please note that this will require a new major version since
phpseclibwould get removed with an update even if it's used in a project. It has to be explicitly required after this PR.