fixed #35: incorrect hmac signature encoding #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@smaxwellstewart thanks for the PR but I don't get why we should return the output of hash_hmac in a raw format. Could you please explain? thanks |
|
@cirpo theres an open issue with a more detailed explanation @smaxwellstewart the changes seem to be ok, but could you fix the tests that are now broken? |
|
I can add fixes for the tests for sure. |
kidtronnix
changed the title
|
Seems like it's all passing apart from HHVM. Anybody have any ideas why that test is faling? Does it matter? |
|
@smaxwellstewart for HHVM it doesn't matter, thanks :) |
|
all good! Im gonna publish a new major, since as soon as you roll the library out old clients using hmac will not work (as verification will not pass for tokens generated pre-fix) |
odino
added a commit
that referenced
this pull request
May 26, 2015
fixed #35: incorrect hmac signature encoding
|
tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.