Make failed key resources throw informative error #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, when keys are passed in as invalid file strings (or potentially other non-resource objects), `PublicKey` fails with the unclear message: ``` Could not create token: openssl_pkey_get_details() expects parameter 1 to be resource, boolean given ``` It would be more helpful if failures to retrieve key resources were communicated directly to the user, so I suggest `getKeyResource` checks its result before submitting and throws an exception if it couldn't successfully get a resource.
|
Ok, I see a bad typo in there! I'll fix that and add some cases to |
|
Hrm. PHPUnit 4.8 doesn't have the same method signature for exception checks. And I guess HHVM actually throws an error when the file isn't found? I wonder if the |
|
Ok, passing all checks! Let me know if you need a squash or any style changes... |
|
👍 great work @tdhsmith, thank for the help! |
|
in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in response to an issue raised in tymondesigns/jwt-auth#763. A couple users were attempting to pass in
file://keys, but having a hard time diagnosing why they would fail. I suggest you utilizeopenssl_error_string()to communicate problems with potential key resources:At the moment, when keys are passed in as invalid file strings (or potentially other non-resource objects),
PublicKeyfails with the unclear message:It would be more helpful if failures to retrieve key resources were communicated directly to the user, so I have
getKeyResourcechecking its result before submitting and throwing an exception if it couldn't successfully create a resource.