Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeleton covers children when show={false} on web #271

Closed
1 task done
adamhari opened this issue Mar 2, 2023 · 4 comments
Closed
1 task done

Skeleton covers children when show={false} on web #271

adamhari opened this issue Mar 2, 2023 · 4 comments

Comments

@adamhari
Copy link

adamhari commented Mar 2, 2023

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

Skeleton is rendering overtop of it's children, regardless of the value of the show prop.

Expected Behavior

Skeleton is not visible and it's children are visible when show is false.

Steps To Reproduce

  1. Add a Skeleton component with show=false.
  2. Add children to the Skeleton

Versions

- Moti: 0.24
- Reanimated: 3.0.0
- React Native Web: 0.18.12

Screenshots

Moti 0.23.7

image

Moti 0.24.0

image

Reproduction

https://stackblitz.com/edit/nextjs-dhaw4c?file=pages%2Findex.tsx,package.json

@nandorojo
Copy link
Owner

Looks like a regression, I’ll look into this tomorrow

@nandorojo
Copy link
Owner

does passing backgroundColor=“transparent” fix it?

@adamhari
Copy link
Author

adamhari commented Mar 2, 2023

does passing backgroundColor=“transparent” fix it?

Yeah, that seems to fix the issue.

@nandorojo
Copy link
Owner

Fixed in 0.24.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants