Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add feature for reading [include and display images from online sources into the reader] #48

Closed
excalibur1010 opened this issue Jun 28, 2022 · 25 comments
Labels
bug Something isn't working Feature request Feature that is not implemented revisit Will check again later on

Comments

@excalibur1010
Copy link

Please Add feature reading mode html
Some novel including embed image

Btw i love your app
Thx for made this app
You are amazing

@nanihadesuka nanihadesuka added the Feature request Feature that is not implemented label Jun 29, 2022
@nanihadesuka
Copy link
Owner

Hey @excalibur1010 do you have any example, link of some novel that has embedded images? That would be the the best way to help implement this feature.

@excalibur1010
Copy link
Author

excalibur1010 commented Jun 29, 2022

Hey @excalibur1010 do you have any example, link of some novel that has embedded images? That would be the the best way to help implement this feature.

Main

https://www.novelupdates.com/series/kurasu-no-daikiraina-joshi-to-kekkon-suru-koto-ni-natta/

Chapter

https://www.novelupdates.com/extnu/6292172/
https://www.novelupdates.com/extnu/6295175/

@nanihadesuka
Copy link
Owner

Added with 4d95b55
Note that still needs some work so that the images are stored fully offline and for taken into account for backup, but aside from that it now works.

The apk installer will be available for the next release (next release time is undefined) but you can still build the app yourself if you want it now.

@Nabeelshar
Copy link
Contributor

Nabeelshar commented Jul 2, 2022

Here is apk with that build.
apk

Technically we can add manga source now.

@excalibur1010
Copy link
Author

Here is apk with that build.
apk

Technically we can add manga source now.

Screenshot_2022-07-02-23-42-33-800_com.google.android.packageinstaller.jpg

Can't install

@Nabeelshar
Copy link
Contributor

Here is apk with that build.
apk
Technically we can add manga source now.

Screenshot_2022-07-02-23-42-33-800_com.google.android.packageinstaller.jpg

Can't install

Properly need to delete previous version as I didn't update the version

@excalibur1010
Copy link
Author

Here is apk with that build.
apk
Technically we can add manga source now.

Screenshot_2022-07-02-23-42-33-800_com.google.android.packageinstaller.jpg

Can't install

Properly need to delete previous version as I didn't update the version

Screenshot_2022-07-02-23-48-38-364_com.android.vending.jpg

Still can't install and blocked by play protect

@Nabeelshar
Copy link
Contributor

Skip it it say that when the app is in debug mode or is not on playstore.
TO check if there is any virus you can test here virustotal by google

@nanihadesuka
Copy link
Owner

Please don't share debug builds, only release ones or at least with optimizations enabled.

@Nabeelshar
Copy link
Contributor

There is optimization?!

@nanihadesuka nanihadesuka changed the title Please add feature for reading Please add feature for reading [include and display images from online sources into the reader] Jul 15, 2022
@nanihadesuka
Copy link
Owner

@excalibur1010 last release with this feature added: https://github.com/nanihadesuka/NovelDokusha/releases/tag/v1.7.0

@excalibur1010
Copy link
Author

excalibur1010 commented Jul 16, 2022

Screenshot_2022-07-17-02-05-49-498_my noveldokusha

Image still not show
@nanihadesuka

@nanihadesuka
Copy link
Owner

@excalibur1010 what chapter is it

@nanihadesuka nanihadesuka reopened this Jul 16, 2022
@excalibur1010
Copy link
Author

Screenshot_2022-07-17-12-47-43-862_my noveldokusha

All chapters
From this novel
Kurasu no Daikiraina Joshi to Kekkon Suru Koto ni Natta
@nanihadesuka

@nanihadesuka
Copy link
Owner

@excalibur1010 are you sure you are on the last version (1.7.0) of the app? I tried several times and all works fine. You could try to redownload the chapters.

@excalibur1010
Copy link
Author

Screenshot_2022-07-18-09-31-03-311_com miui securitycenter
Screenshot_2022-07-18-09-32-11-816_my noveldokusha

Already try redownload
Still same

@Nabeelshar
Copy link
Contributor

IMG_20220718_142248.jpg

It's showing this.

@excalibur1010
Copy link
Author

IMG_20220718_142248.jpg

It's showing this.

Screenshot_2022-07-19-17-20-43-356_my noveldokusha

My mine it's not like that

@nanihadesuka nanihadesuka added the revisit Will check again later on label Jul 25, 2022
@nanihadesuka
Copy link
Owner

Unable to reproduce, will leave it as it is for now.

@nanihadesuka
Copy link
Owner

@excalibur1010 still unable to see images? If fixed, close this issue please.

@nanihadesuka
Copy link
Owner

Closed, will be considered fixed unless more complains are received

@wasu-code
Copy link

I'm having the same issue: instead of image html tag is displayed. I tried it with cheaper OP provided and local EPUB

App version: 2.0.1

@nanihadesuka nanihadesuka reopened this Nov 26, 2023
@nanihadesuka nanihadesuka added the bug Something isn't working label Mar 23, 2024
@nanihadesuka
Copy link
Owner

Unfortunately I can't seem to reproduce the issue, will keep open :/

@nanihadesuka
Copy link
Owner

Issue still happening?

@nanihadesuka
Copy link
Owner

nanihadesuka commented Jul 29, 2024

Very old issue. (I) haven't been able to reproduce the bug in the new version. I will close for now and assume is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Feature request Feature that is not implemented revisit Will check again later on
Projects
None yet
Development

No branches or pull requests

4 participants