Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows tests not working #1504

Closed
ilkerhalil opened this issue Sep 6, 2021 · 6 comments
Closed

Windows tests not working #1504

ilkerhalil opened this issue Sep 6, 2021 · 6 comments

Comments

@ilkerhalil
Copy link

Describe the bug
When I build for windows in nng two tests are not working.

** Environment Details **
cmake -DNNG_ELIDE_DEPRECATED=ON -DNNG_TOOLS=OFF -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release
cmake --build . --config Release

Additional context
The following tests FAILED:
37 - nng.inproc_lat (Exit code 0xc0000135
)
38 - nng.inproc_thr (Exit code 0xc0000135
)

@gdamore
Copy link
Contributor

gdamore commented Sep 6, 2021

What version are you using? (Perhaps the git commit you're working with?)

@ilkerhalil
Copy link
Author

The final version of the master branch, commit id d137bf3

@gdamore
Copy link
Contributor

gdamore commented Sep 6, 2021

If you checkout d4b9121 does it suffer from the same problem? I'm wondering specifically if that commit introduced a regression -- I merged it earlier than I intended, but I haven't backed it out because I think the changes are benign -- but I might change my story on that if it does introduce a regression.

@gdamore
Copy link
Contributor

gdamore commented Sep 6, 2021

These tests are passing both in CI/CD, and on my Windows 10 box:

  Start 37: nng.inproc_lat

37/81 Test #37: nng.inproc_lat .............................. Passed 0.61 sec
Start 38: nng.inproc_thr
38/81 Test #38: nng.inproc_thr .............................. Passed 0.40 sec

@gdamore
Copy link
Contributor

gdamore commented Sep 6, 2021

I'm wondering if the problem is shared libs... if those tools are built shared, and the test code cannot find the shared libraries at link time, that might be a source of problem. The various problems with resolving shared libraries in different environments have been a never ending source of headaches.

@gdamore
Copy link
Contributor

gdamore commented Nov 28, 2021

To be honest, those two tests are probably not much of a concern -- they are basic latency and throughput tests. My guess is that something in the execution environment is causing them to fail -- likely the way the library is built vs how the tools are built.

Anyway, since they aren't failing in windows CI/CD, I'm going to close this for now.

@gdamore gdamore closed this as completed Nov 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants