Don't need virtual destructor to be pure virtual when we already have…

… pure virtual functions
nanoporetech · Dec 14, 2023 · b7548a3 · b7548a3
1 parent c0d6e58
commit b7548a3
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/dorado/basecall/ModelRunner.h b/dorado/basecall/ModelRunner.h
@@ -14,7 +14,7 @@ namespace dorado::basecall {
 
 class ModelRunnerBase {
 public:
-    virtual ~ModelRunnerBase() = 0;
+    virtual ~ModelRunnerBase() = default;
     virtual void accept_chunk(int chunk_idx, const at::Tensor &chunk) = 0;
     virtual std::vector<decode::DecodedChunk> call_chunks(int num_chunks) = 0;
     virtual const CRFModelConfig &config() const = 0;
@@ -27,8 +27,6 @@ class ModelRunnerBase {
     virtual stats::NamedStats sample_stats() const = 0;
 };
 
-inline ModelRunnerBase::~ModelRunnerBase() = default;
-
 using RunnerPtr = std::unique_ptr<ModelRunnerBase>;
 
 template <typename T>