Skip to content
This repository has been archived by the owner on Mar 23, 2023. It is now read-only.

Use pyranges for overlap logic #32

Open
eharr opened this issue Nov 12, 2019 · 3 comments
Open

Use pyranges for overlap logic #32

eharr opened this issue Nov 12, 2019 · 3 comments
Labels
enhancement New feature or request

Comments

@eharr
Copy link
Contributor

eharr commented Nov 12, 2019

Some of the overlap logic implemented in GenomeIntervalDf could be replaced with calls to the better documented and tested pyranges api.
@eharr eharr added the enhancement New feature or request label Nov 12, 2019
@eharr eharr mentioned this issue Nov 12, 2019
Closed
@endrebak
Copy link

Actually, the NCLS is tested extensively in the pyranges tests, but indirectly.

@eharr
Copy link
Contributor Author

eharr commented Nov 13, 2019

Actually, the NCLS is tested extensively in the pyranges tests, but indirectly.
Ah sorry, I meant better tested than the pore-c implementation.

@endrebak
Copy link

Also, I would love to help out if you have reasonable feature-requests for pyranges. Or feel free to ping me for help :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eharr @endrebak