Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make API surface consistent for android #52

Closed
muntact opened this issue Sep 19, 2017 · 2 comments
Closed

Make API surface consistent for android #52

muntact opened this issue Sep 19, 2017 · 2 comments

Comments

@muntact
Copy link

muntact commented Sep 19, 2017

Hey,

I know that Andorid isn't currently supported but it would be nice if i could call the isSupported function in a consistent manner and expect it to simply say 'No this isn't supported' on android the same way i would expect it to happen on IOS, i.e. return a Promise which resolves false.

Currently i have a hack in my node_modules to locally fix this problem:

/**
 * Stub of TouchID for Android.
 *
 * @providesModule TouchID
 * @flow
 */
'use strict';

export default {
  isSupported() {
    return new Promise((resolve, reject) => {
      resolve(false);
    });
  }
};
@zibs
Copy link
Collaborator

zibs commented Sep 19, 2017

hey @muntact you're definitely not the only person with this concern. I've just made a PR to support android #53 , and the api is now consistent between the platforms.

@zibs
Copy link
Collaborator

zibs commented Dec 5, 2017

This will be fixed in the latest release - happening sometime this week.

@zibs zibs closed this as completed Dec 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants