New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added environment creation and doc tools install #72
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Made some minor changes.
There's some changes in the Installation too including the python version. That is also being changed here #51 with Chris-N-K#2
to be able to change python version in conf.py and use substitutions.
BTW I'm not sure we're officially recommending 3.10 now? CC: @jni
Thanks @psobolewskiPhD - I think I addressed most of your suggestions. The shields had been proposed by the original author - I am ok either way. |
@melissawm Instead of the shields, perhaps this is a good place to use the version substitution #84 This could be merged as is and then editted in that PR or the other way around. 🤷♂️ |
Actually, the conda env creation could also be replaced with the substitution from #84 |
That's a good idea - let me do that! |
@melissawm So maybe we should get #84 merged before this one? |
Yes - that would be helpful! |
Merged! |
This is a redo of napari/napari#4827. Co-authored-by: Rob Kozar <rwkozar88@yahoo.com>
096ee0a
to
26bcfcd
Compare
I think I got all your comments - let me know if there's anything else. Cheers! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @melissawm thank you for these updates! My apologies for the delayed review as well - I've made just three small comments, but it's looking good!
* Moving conda installation to be the first tab * Moving contributing documentation section up * Adding manual backend installation note
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 🎉
@psobolewskiPhD conflicts are fixed :) |
Description
This is a redo of napari/napari#4827. Also includes some reorganization on the contributing guide. cc @rwkozar
Co-authored-by: Rob Kozar rwkozar88@yahoo.com
Type of change
References
Closes #46
Depends on #63 for the nice sphinx-design tabs :)
Final checklist: