-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributing docs for [dev] install change needing Qt backend install #78
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @psobolewskiPhD , this looks great to me. Just wondering if we can integrate with #72 as well? Or maybe scrap that if it's not useful. Thanks!
Ah, I forgot about that one. This specific PR is to account for the napari/napari PR changing [dev]—which may not be merged, I'm not sure what the consensus is. |
I might be confusing my bash syntax here, but I think if you put a space in the list of packages ( |
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
Co-authored-by: Grzegorz Bokota <bokota+github@gmail.com>
I don't really understand the plan here... Are we merging #72 and then this one, the reverse, or cherry-picking the changes of one PR into the other? Either way I'm ok with this being merged soon, and happy to pull the simul-trigger on napari/napari#5438 and here! |
Description
This PR updates the contribution docs for the changes to the installation pattern to remove [all] from [dev]. This means that doing a
pip install -e .[dev]
will no longer install a Qt backend (currently pyqt5). As a result, a Qt backend needs to be installed along side [dev] or be pre-existing. The goal is to make it easier for people to test other Qt backends than pyqt5 or when using platforms that don't have pyqt5 wheels on pypi (e.g. macOS arm64).Type of change
References
This is needed in pair with napari PR: napari/napari#5438
Final checklist: