-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: implement python version substitution in conf.py #84
Feature: implement python version substitution in conf.py #84
Conversation
@Czaki I added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me. I know this may be out of scope for this PR, but while we're at it, could we also bump the version mentioned in the quickstart guide? Currently it says
This tutorial uses napari 0.4.14.
I have found these places that for me should be addressed in this PR: docs/docs/tutorials/fundamentals/installation.md Lines 215 to 216 in d1c2878
docs/docs/tutorials/fundamentals/installation.md Lines 256 to 258 in d1c2878
docs/docs/tutorials/fundamentals/quick_start.md Lines 53 to 55 in d1c2878
|
@Czaki I saw those—are any of them still actual? |
The content of installation.md is connected with artifacts from https://github.com/napari/napari/blob/1eb5e3142063630a49dd30705c9aa2ff3cc1866b/.github/workflows/make_bundle.yml - it is pure napari repository. We still have workflow for conda build https://github.com/napari/napari/blob/1eb5e3142063630a49dd30705c9aa2ff3cc1866b/.github/workflows/make_bundle_conda.yml So when looking at the current state of the repository, both are actual. And I do not see an Issue or PR for removing this now. |
@melissawm I didn't change that because I'm not sure we want versions in guides/tutorials changing automatically when the variable is bumped in |
@Czaki I updated the quick_start links to use the substituted version to link directly to latest stable. However, looking at it more, I think the whole guide for the bundle app So I think this is out-of-scope of this PR, which is intended to provide the framework of substitutions. I did go ahead and add a link in the first paragraph to go directly to the current stable release using |
Description
This PR is a leftover from #51
The idea was from @Czaki Chris-N-K#1 (comment)
Basically, the python version shown in various places should be globally set in
conf.py
once and then substitutions used.At the moment, I've set the python version to 3.9, but I at some point we should consider switching to 3.10.
Type of change
References
Final checklist: