New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate qt_viewer.screenshot
& clipboard
#3765
deprecate qt_viewer.screenshot
& clipboard
#3765
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. This now has conflicts (because i got trigger happy on #3066). I'll follow whatever you recommend for fixing @tlambert03 - if you want to revert my merge or if we just press on
Codecov Report
@@ Coverage Diff @@
## main #3765 +/- ##
==========================================
+ Coverage 83.05% 83.10% +0.05%
==========================================
Files 563 572 +9
Lines 46524 46972 +448
==========================================
+ Hits 38642 39038 +396
- Misses 7882 7934 +52
Continue to review full report at Codecov.
|
* deprecate qt_viewer.screenshot & clipboard * not private yet * fix tests
Description
Looking into changing the examples for #3066, at least some of the public usage is just to access
clipboard
andscreenshot
. Since those methods already exist onviewer.window
, which is intended to be our public "gui related" api, this PR deprecates direct usage ofviewer.window.qt_viewer.screenshot()
in favor ofviewer.window.screenshot(canavs_only=True)
(matching thecanvas_only
kwarg already used in Viewer and nbscreenshot)Type of change
References
How has this been tested?
Final checklist:
trans.
to make them localizable.For more information see our translations guide.