Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Postpone qt_viewer deprecation to 0.6.0 #6283

Merged
merged 1 commit into from Oct 2, 2023
Merged

Postpone qt_viewer deprecation to 0.6.0 #6283

merged 1 commit into from Oct 2, 2023

Conversation

Czaki
Copy link
Collaborator

@Czaki Czaki commented Oct 2, 2023 •
edited by github-actions bot

Description

As we do not implemented some of API yet, I would like to dellay viewer.window.qt_viewer to 0.6.0

@Czaki Czaki added the maintenance PR with maintance changes, label Oct 2, 2023
@Czaki Czaki added this to the 0.4.19 milestone Oct 2, 2023
@github-actions github-actions bot added the qt Relates to qt label Oct 2, 2023
@codecov
Copy link

codecov bot commented Oct 2, 2023 •
edited

Codecov Report

Merging #6283 (d0f5583) into main (7ed4ea8) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is 50.00%.

@@           Coverage Diff           @@
##             main    #6283   +/-   ##
=======================================
  Coverage   91.71%   91.71%           
=======================================
  Files         585      585           
  Lines       51540    51542    +2     
=======================================
+ Hits        47269    47273    +4     
+ Misses       4271     4269    -2
Files Coverage Δ
napari/_qt/qt_main_window.py 75.39% <ø> (ø)
napari/utils/color.py 92.59% <50.00%> (-3.41%) ⬇️

... and 1 file with indirect coverage changes

DragaDoncila
DragaDoncila approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@DragaDoncila DragaDoncila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving as I agree we shouldn't hold 0.5.0 until we figure this out

psobolewskiPhD
psobolewskiPhD approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree. We have a fair amount on the 0.5.0 plate already.

@DragaDoncila DragaDoncila added the ready to merge Last chance for comments! Will be merged in ~24h label Oct 2, 2023
@Czaki Czaki merged commit c3207fa into napari:main Oct 2, 2023
40 checks passed
@Czaki Czaki deleted the qt_viewer_deprecation branch October 2, 2023 21:32
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Oct 2, 2023
This was referenced Oct 15, 2023
Open
Open
Open
Czaki added a commit that referenced this pull request Oct 17, 2023
@Czaki
Postpone qt_viewer deprecation to 0.6.0 (#6283)
92f9eaa
@GenevieveBuckley GenevieveBuckley mentioned this pull request Oct 23, 2023
Merged
@Czaki Czaki added highlight PR that should be mentioned in next release notes deprecation Adds a deprecation warning labels Oct 23, 2023
Carreau pushed a commit that referenced this pull request Oct 26, 2023
@GenevieveBuckley
Update examples/clipboard_.py to fix FutureWarning (#6365)
08cd9fe 
Closes #6364

I've updated the example script to no longer access the clipboard via
`viewer.window.qt_viewer.clipboard` (which we plan to deprecate).
Instead we now use `viewer.window.clipboard` directly (which is part of
the external API).

Related:
* #3765
* #6283
@imagesc-bot
Copy link

This pull request has been mentioned on Image.sc Forum. There might be relevant details there:

https://forum.image.sc/t/request-for-testing-napari-0-4-19-release-candidate/87972/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Carreau Carreau Carreau approved these changes

@DragaDoncila DragaDoncila DragaDoncila approved these changes

@psobolewskiPhD psobolewskiPhD psobolewskiPhD approved these changes

Assignees

@Czaki Czaki

Labels
deprecation Adds a deprecation warning highlight PR that should be mentioned in next release notes maintenance PR with maintance changes, qt Relates to qt
Projects
None yet
Milestone
0.4.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Czaki @imagesc-bot @Carreau @DragaDoncila @psobolewskiPhD