Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples/clipboard_.py to fix FutureWarning #6365

Merged
merged 1 commit into from Oct 26, 2023

Conversation

GenevieveBuckley
Copy link
Contributor

References and relevant issues

Closes #6364

Description

This turns out to be a pretty simple fix.

I've updated the example script to no longer access the clipboard via viewer.window.qt_viewer.clipboard (which we plan to deprecate). Instead we now use viewer.window.clipboard directly (which is part of the external API).

Related:

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #6365 (6fa709e) into main (e7f68dd) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #6365      +/-   ##
==========================================
- Coverage   91.98%   91.92%   -0.07%     
==========================================
  Files         596      596              
  Lines       52680    52680              
==========================================
- Hits        48458    48425      -33     
- Misses       4222     4255      +33     

see 11 files with indirect coverage changes

Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shall we milestone this with 0.5.0?
It's not worth backporting I don't think...

@psobolewskiPhD psobolewskiPhD added maintenance PR with maintance changes, ready to merge Last chance for comments! Will be merged in ~24h labels Oct 23, 2023
@psobolewskiPhD psobolewskiPhD added this to the 0.5.0 milestone Oct 23, 2023
@Carreau Carreau added maintenance PR with maintance changes, and removed maintenance PR with maintance changes, labels Oct 25, 2023
@Carreau
Copy link
Contributor

Carreau commented Oct 26, 2023

This got the "Ready-to-merge" label 2 days ago and got no objections. Merging to move the queue forward.

Thanks.

@Carreau Carreau merged commit 08cd9fe into napari:main Oct 26, 2023
35 of 37 checks passed
@Carreau Carreau removed the ready to merge Last chance for comments! Will be merged in ~24h label Oct 26, 2023
@GenevieveBuckley GenevieveBuckley deleted the update-clipboard-example branch October 26, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR with maintance changes,
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FutureWarning in example script clipboard_.py
4 participants