Do not use native dialog for reset shortcuts #6493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6493 +/- ##
==========================================
- Coverage 92.24% 92.17% -0.07%
==========================================
Files 601 601
Lines 53210 53216 +6
==========================================
- Hits 49081 49052 -29
- Misses 4129 4164 +35 ☔ View full report in Codecov by Sentry. |
|
This fixes the keybinding dialog, but when testing I noticed the overall preferences reset dialog has the same behavior. I made a PR to your branch with the analogous fix to the other dialog which fixes it locally for me--hopefully I didn't mess it up! |
github-actions
bot
added
the
preferences
|
Maybe we should switch this into a contextmanager? |
psobolewskiPhD
approved these changes
Nov 29, 2023
Carreau
removed
the
ready to merge
Czaki
added a commit
that referenced
this pull request
Dec 15, 2023
# References and relevant issues closes #6490 # Description Since Qt6==6.5.0 on Macos, the Qt starts using native dialog even if it does not support all buttons (in our case `QMessageBox.StandardButton.RestoreDefaults`). This solution is inspired by comments from https://bugreports.qt.io/browse/QTBUG-116757 If someone has time, please try to open the Bug report there. After the last discussions about patching enum, I do not feel fluent enough to write in English to talk with them. An alternative solution will be to change the button on the supported one. Or change the native flag globally, but the second one may impact File Dialogs. --------- Co-authored-by: Peter Sobolewski <pete.sd@gmail.com>
kne42
added a commit
to kne42/napari
that referenced
this pull request
Dec 20, 2023
* main: (80 commits) Check in LabelColormap that fewer than 2**16 colors are requested (napari#6540) Fix label color shuffling by also updating colormap size (napari#6460) Add `_block_refresh()` to layers (napari#6525) MNT: Use `partial` in samples menu to avoid leaking (napari#6538) Update performance and reduce memory usage for big Labels layer in direct color mode (napari#6439) Reset single step and decimals on reset range slider in popup (napari#6523) Add copy operator to fix memory benchmarks (napari#6530) Restore quit shortcut (napari#6526) Fix problem with invalidate cache (napari#6520) [pre-commit.ci] pre-commit autoupdate (napari#6505) Pass key event from Main window to our internal mechanism (napari#6419) Typing: Fully type 5 more files (napari#6361) Do not use native dialog for reset shortcuts (napari#6493) Use views rather than CPU-based hashing for 8- and 16-bit Labels data (napari#6467) Add import lint back to CI (napari#6506) Type napari.layers.image helper sub-modules (napari#6499) Bugfix: ensure gamma and opacity are floats (napari#6498) FIX: Remove `None` default from `_remove_dock_widget` (napari#6481) Add testing_extra and optional dependencies when creating constraints (napari#6487) Run test suite with optional dependencies and fix tests when `triangle` is installed (napari#6488) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References and relevant issues
closes #6490
Description
Since Qt6==6.5.0 on Macos, the Qt starts using native dialog even if it does not support all buttons (in our case
QMessageBox.StandardButton.RestoreDefaults).This solution is inspired by comments from https://bugreports.qt.io/browse/QTBUG-116757
If someone has time, please try to open the Bug report there. After the last discussions about patching enum, I do not feel fluent enough to write in English to talk with them.
An alternative solution will be to change the button on the supported one. Or change the native flag globally, but the second one may impact File Dialogs.