Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Type napari.layers.image helper sub-modules #6499

Merged
merged 4 commits into from Nov 28, 2023

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Nov 26, 2023

Type image._image_utils, image._image_mouse_bindings, image._image_key_bindings
and image._image_constants

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (514b40a) 92.23% compared to head (2bb12c3) 92.18%.

Files Patch % Lines
napari/layers/image/_image_mouse_bindings.py 37.50% 5 Missing ⚠️
napari/layers/image/_image_key_bindings.py 73.33% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6499      +/-   ##
==========================================
- Coverage   92.23%   92.18%   -0.05%     
==========================================
  Files         601      601              
  Lines       53226    53231       +5     
==========================================
- Hits        49093    49071      -22     
- Misses       4133     4160      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Carreau Carreau added maintenance PR with maintance changes, typing PR that focus on typing improvement labels Nov 27, 2023
@Carreau Carreau added this to the 0.5.0 milestone Nov 27, 2023
@Carreau Carreau added the ready to merge Last chance for comments! Will be merged in ~24h label Nov 27, 2023
@Carreau Carreau merged commit 7405c53 into napari:main Nov 28, 2023
39 checks passed
@dstansby dstansby deleted the more-typing-VI branch November 28, 2023 14:33
@Czaki Czaki removed the ready to merge Last chance for comments! Will be merged in ~24h label Dec 12, 2023
kne42 added a commit to kne42/napari that referenced this pull request Dec 20, 2023
* main: (80 commits)
  Check in LabelColormap that fewer than 2**16 colors are requested (napari#6540)
  Fix label color shuffling by also updating colormap size (napari#6460)
  Add `_block_refresh()` to layers (napari#6525)
  MNT: Use `partial` in samples menu to avoid leaking  (napari#6538)
  Update performance and reduce memory usage for big Labels layer in direct color mode (napari#6439)
  Reset single step and decimals on reset range slider in popup (napari#6523)
  Add copy operator to fix memory benchmarks (napari#6530)
  Restore quit shortcut (napari#6526)
  Fix problem with invalidate cache  (napari#6520)
  [pre-commit.ci] pre-commit autoupdate (napari#6505)
  Pass key event from Main window to our internal mechanism (napari#6419)
  Typing: Fully type 5 more files (napari#6361)
  Do not use native dialog for reset shortcuts (napari#6493)
  Use views rather than CPU-based hashing for 8- and 16-bit Labels data (napari#6467)
  Add import lint back to CI (napari#6506)
  Type napari.layers.image helper sub-modules (napari#6499)
  Bugfix: ensure gamma and opacity are floats (napari#6498)
  FIX: Remove `None` default from `_remove_dock_widget` (napari#6481)
  Add testing_extra and optional dependencies when creating constraints (napari#6487)
  Run test suite with optional dependencies and fix tests when `triangle` is installed (napari#6488)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance PR with maintance changes, typing PR that focus on typing improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants