Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake Error at tools/napkin/CMakeLists.txt:218 (if): #24

Closed
sphaero opened this issue May 15, 2024 · 2 comments
Closed

CMake Error at tools/napkin/CMakeLists.txt:218 (if): #24

sphaero opened this issue May 15, 2024 · 2 comments

Comments

@sphaero
Copy link

sphaero commented May 15, 2024

  if given arguments:

    "STREQUAL" "Release"

  Unknown arguments specified

This is with cmake 3.29

Fix:

diff --git a/tools/napkin/CMakeLists.txt b/tools/napkin/CMakeLists.txt
index fabca61ea..de0f76505 100644
--- a/tools/napkin/CMakeLists.txt
+++ b/tools/napkin/CMakeLists.txt
@@ -215,7 +215,7 @@ if(APPLE)
         
 
 elseif(UNIX)
-    if (${CMAKE_BUILD_TYPE} STREQUAL "Release")
+    if ("${CMAKE_BUILD_TYPE}" STREQUAL "Release")
         list(APPEND DEEP_DEPENDENT_RPATHS ${PATH_TO_THIRDPARTY}/Qt/lib)
         list(APPEND DEEP_DEPENDENT_RPATHS lib)
@cklosters
Copy link
Member

cklosters commented May 22, 2024

Could you submit this as a PR instead of logging it as a bug? NAP ships with it's own version of CMAKE (cmake version 3.21.3) in thirdparty and that's the one we support. Your change is compiled and validated, ensuring the change doesn't break existing builds.

@cklosters
Copy link
Member

Not an issue with current supported cmake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants