Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modified index.css file #230

Merged
merged 3 commits into from
Mar 4, 2023
Merged

Modified index.css file #230

merged 3 commits into from
Mar 4, 2023

Conversation

vk20july
Copy link
Contributor

@vk20july vk20july commented Mar 4, 2023 •
edited
Loading

@narayansoni Please review my code

github-actions[bot]
github-actions bot reviewed Mar 4, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

narayan954
narayan954 requested changes Mar 4, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not working for different screens, for example mobile. Can you find why or fix it?

@narayan954 narayan954 linked an issue Mar 4, 2023 that may be closed by this pull request
Scroll to top button not at center #229
Closed
@vk20july
Copy link
Contributor Author

vk20july commented Mar 4, 2023

ok let me see

@narayan954
Copy link
Owner

ok let me see

images for your reference. btw this issue arrived in pr #218 if that helps
mobile view
web view

@vk20july
Copy link
Contributor Author

vk20july commented Mar 4, 2023

ok sir thank you

@vk20july
Copy link
Contributor Author

vk20july commented Mar 4, 2023

@narayan954 made the required changes please review

narayan954
narayan954 approved these changes Mar 4, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 0f7581b into narayan954:master Mar 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions github-actions left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
easy
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scroll to top button not at center
2 participants
@vk20july @narayan954