Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closes #182 [Theme Mode] #218

Merged
merged 6 commits into from
Mar 1, 2023
Merged

Closes #182 [Theme Mode] #218

merged 6 commits into from
Mar 1, 2023

Conversation

sarkartanmay393
Copy link
Contributor

Light Mode:

image

Dark Mode:

image

@sarkartanmay393
Copy link
Contributor Author

@narayan954 Review my PR

github-actions[bot]
github-actions bot reviewed Feb 28, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

@narayan954 narayan954 linked an issue Feb 28, 2023 that may be closed by this pull request
Improve dark mode #182
Closed
@narayan954
Copy link
Owner

@narayan954 Review my PR

Hi @sarkartanmay393 you missed some elements like the text_input , can you please go through and confirm it and/or fix it. Also, please check for something else left on your side as well. I have my exams going on for another 1 day so I wont be available too long. Sorry for the inconvenience for one more day.
issue182

Thank you

@sarkartanmay393
Copy link
Contributor Author

@narayan954 you can review and merge, as soon as possible. JWOC P1 is ending soon.

@narayan954
Copy link
Owner

@narayan954 you can review and merge, as soon as possible. JWOC P1 is ending soon.

okay tanmay, reviewing asap

@narayan954
Copy link
Owner

scroll to top button is no more at the center, can you look at it @sarkartanmay393 , else it's okay

narayan954
narayan954 approved these changes Mar 1, 2023
View reviewed changes
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit 5af2310 into narayan954:master Mar 1, 2023
@narayan954
Copy link
Owner

Thanks for your contribution!!

@sarkartanmay393 sarkartanmay393 mentioned this pull request Mar 1, 2023
Closed
@sarkartanmay393 sarkartanmay393 deleted the feature/DarkMode branch March 1, 2023 14:59
narayan954 added a commit to AK-shat-JAIN/dummygram that referenced this pull request Mar 4, 2023
@narayan954
Squashed commit of the following:
43911e7 
commit b08bcc2
Merge: 0d2a720 f27c1dc
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Thu Mar 2 15:17:16 2023 +0530

    Merge pull request narayan954#224 from narayan954/deepsource-transform-b2036ef1

commit f27c1dc
Author: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date:   Thu Mar 2 09:30:02 2023 +0000

    Format code with prettier

    This commit fixes the style issues introduced in 0d2a720 according to the output
    from prettier.

    Details: https://deepsource.io/gh/narayan954/dummygram/transform/293f1d52-4755-4ea8-be7b-9949010c717b/

commit 0d2a720
Merge: b9375ae 75c8271
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Thu Mar 2 14:59:39 2023 +0530

    Merge pull request narayan954#222 from sarkartanmay393/feature/LoginPages

commit 75c8271
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Thu Mar 2 14:40:31 2023 +0530

    fixed signup redirect

commit 0a65ccb
Author: Tanmay Sarkar <sarkartanmay393@gmail.com>
Date:   Thu Mar 2 12:32:27 2023 +0530

    Fix: minor

commit 57dd072
Author: Tanmay Sarkar <sarkartanmay393@gmail.com>
Date:   Thu Mar 2 12:08:32 2023 +0530

    Fix: noauth user to LoginScreen

commit 7e837a6
Author: Tanmay Sarkar <sarkartanmay393@gmail.com>
Date:   Wed Mar 1 21:47:54 2023 +0530

    Fix: AuthScreen functionality

commit f8e7c8d
Author: Tanmay Sarkar <sarkartanmay393@gmail.com>
Date:   Wed Mar 1 21:22:57 2023 +0530

    Add: login signup initials

commit b9375ae
Merge: 5af2310 18e40cb
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Mar 1 20:26:25 2023 +0530

    Merge pull request narayan954#221 from narayan954/deepsource-transform-21500910

commit 18e40cb
Author: deepsource-autofix[bot] <62050782+deepsource-autofix[bot]@users.noreply.github.com>
Date:   Wed Mar 1 14:54:34 2023 +0000

    Format code with prettier

    This commit fixes the style issues introduced in 5af2310 according to the output
    from prettier.

    Details: https://deepsource.io/gh/narayan954/dummygram/transform/e84265f7-5492-47b1-b900-461d746f5133/

commit 5af2310
Merge: 637610c 08261da
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Wed Mar 1 20:24:18 2023 +0530

    Merge pull request narayan954#218 from sarkartanmay393/feature/DarkMode

commit 08261da
Author: Tanmay Sarkar <sarkartanmay393@gmail.com>
Date:   Wed Mar 1 14:34:35 2023 +0530

    Fix: theme

commit 430b06d
Author: Tanmay Sarkar <sarkartanmay393@gmail.com>
Date:   Wed Mar 1 14:27:46 2023 +0530

    Fix: minors

commit 2369ed7
Merge: 10aa358 c8fc312
Author: Tanmay Sarkar <sarkartanmay393@gmail.com>
Date:   Wed Mar 1 14:27:06 2023 +0530

    Merge remote-tracking branch 'origin/feature/DarkMode' into feature/DarkMode

commit 10aa358
Author: Tanmay Sarkar <sarkartanmay393@gmail.com>
Date:   Wed Mar 1 14:26:19 2023 +0530

    Fix: Theme

commit c8fc312
Merge: 55e6792 637610c
Author: Narayan soni <narayansoni854@gmail.com>
Date:   Tue Feb 28 23:07:00 2023 +0530

    Merge branch 'master' into pr/218

commit 55e6792
Author: Tanmay Sarkar <sarkartanmay393@gmail.com>
Date:   Tue Feb 28 13:00:24 2023 +0530

    Add: Simple theme mode
@narayan954 narayan954 mentioned this pull request Mar 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@narayan954 narayan954 narayan954 approved these changes

Assignees
No one assigned
Labels
hard
Projects
Dummygram
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve dark mode
2 participants
@sarkartanmay393 @narayan954