Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sidebar frontend #437

Merged
merged 9 commits into from
Jun 11, 2023
Merged

Added sidebar frontend #437

merged 9 commits into from
Jun 11, 2023

Conversation

sumitkr2000
Copy link
Contributor

Hey @narayan954 I have added the frontend of sidebar. I have attached the screenshot of it. Please review my pr and merge it. Thank you!

image

  • Tablet version:-

image

  • Mobile version:-

image

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there, Thanks a lot for your first pull request, we'll be reviewing it asap :)

@narayan954 narayan954 linked an issue Jun 5, 2023 that may be closed by this pull request
Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've mentioned some changes.... for now just copy useCase of some of the elements as asked(no need to make new components for now). Don't remove them from original implementation. We'll remove them later on. Also fix the navbar to sidebar

src/components/Navbar.jsx Outdated Show resolved Hide resolved
src/App.jsx Outdated Show resolved Hide resolved
@sumitkr2000
Copy link
Contributor Author

@narayan954 I have made changes. Please review the pr.

Copy link
Owner

@narayan954 narayan954 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@narayan954 narayan954 merged commit abf1667 into narayan954:master Jun 11, 2023
@sumitkr2000 sumitkr2000 deleted the sidebar branch June 21, 2023 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

[FEATURE] <description> Add a left navbar
2 participants