#445-favourite section #447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @narayan954 do verify this |
Yes, sure allow me some time. |
|
@Soulpurr , can you please match it against the current implementation and adapt/improve it? |
The sidebar one right? |
yes |
hii @narayan954 i have updated this according to #437 as it doesn't have fav section for smaller screen i have added it so pls verify and approve it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So i have added a separate favourite post section.
Right now in order to navigate favourite section its link is located at the profile bar which is fine as of now and for mobile devices.
But after merging #437 we can directly navigate from sidebar for larger screens.
You just need to add a link to this page in sidebar favourite item.
fixes #445
scrnli_08_06_2023_13-33-16.webm