Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1. Have a note counter that when pianist has played 2000 notes, there is a bang to close the piece (like we did for Bilbao) #13

Closed
narcode opened this issue Nov 4, 2017 · 6 comments
Labels

Comments

@narcode
Copy link
Owner

narcode commented Nov 4, 2017

This is not really a conditional. It's more like a self destruct button

@narcode
Copy link
Owner Author

narcode commented Nov 4, 2017

💣

@borrob
Copy link
Contributor

borrob commented Nov 5, 2017

Suggestion
In CodeKlavier.mottipets_classes.py have the method parse_midi return True or False if the parsing succeeded. Then in motippets.motippets.py check if the parsing indeed was successful and then increment a counter (or decrement a countdown). In the while True loop check if the counter hits the maximum number of notes and then break the while-loop.

@narcode
Copy link
Owner Author

narcode commented Nov 5, 2017

👍 exactly. Although the idea is that Anne can code the self-destruct mode whenever she wants, and also choose the N notes before 💣 ... so the counter should start once anne puts the blocks together... so we need a function that checks for the correct blocks and then it 'activates' the counter the way u suggest

@borrob
Copy link
Contributor

borrob commented Nov 5, 2017

How world she activate it? Just as another motif that she can 🎹?

@narcode
Copy link
Owner Author

narcode commented Nov 6, 2017

yeah, or a combination of motifs. a specific sequence of motifs so to speak

@borrob borrob mentioned this issue Nov 6, 2017
@narcode narcode added the pending label Nov 7, 2017
@narcode
Copy link
Owner Author

narcode commented Nov 27, 2017

In the end the countdown became not notes but seconds. We used your ASCII bomb and countDOWN idea @borrob so THANKS!!! awesome. 💣 🎆 🥇

@narcode narcode closed this as completed Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants