Skip to content
This repository has been archived by the owner on Feb 10, 2023. It is now read-only.

[Feature] Add enable Input to ngt-cannon-debug #62

Closed
IRobot1 opened this issue Feb 20, 2022 · 3 comments
Closed

[Feature] Add enable Input to ngt-cannon-debug #62

IRobot1 opened this issue Feb 20, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@IRobot1
Copy link
Contributor

IRobot1 commented Feb 20, 2022

Add enable Input to ngt-cannon-debug so that when false, its easy to disable without having to remove from markup. Default is true.

<ngt-cannon-debug [enable]="false" [scale]="1.1" color="black">
...
@nartc
Copy link
Owner

nartc commented Feb 21, 2022

This seems trivial enough. Would you like to make a PR?

@nartc nartc added the good first issue Good for newcomers label Feb 21, 2022
@IRobot1
Copy link
Contributor Author

IRobot1 commented Feb 21, 2022

I took a look at your build environment. Looks like its setup for Linux and there's several tools I'm not familiar with.

For now, I'm going to pass. It would distract me from what I'm really trying to accomplish with the library.

@nartc nartc added the enhancement New feature or request label Feb 22, 2022
@nartc nartc closed this as completed in c4823f9 Feb 22, 2022
@IRobot1
Copy link
Contributor Author

IRobot1 commented Feb 22, 2022

Thanks. Works great!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@IRobot1 @nartc