Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] Move class-transformer to peer deps #4

Closed
iamolegga opened this issue Nov 8, 2019 · 2 comments
Closed

[question] Move class-transformer to peer deps #4

iamolegga opened this issue Nov 8, 2019 · 2 comments

Comments

@iamolegga
Copy link

Hi, thanks for this library, I'm really interesting in it, and thinking of using it soon, so I have one minor question/suggestion about moving class-transformer to peer deps, because when using this library via nestjsx-automapper there is a chance that class-transformer is using already in nestjs project. What do you think?

@nartc
Copy link
Owner

nartc commented Nov 8, 2019

Good point. Actually, class-transformer used to be listed as peerDeps but then I make it deps to save the library consumers the hassle of installing class-transformer just for AutoMapper. But again, there probably won't be much usage for AutoMapper outside of NestJS ecosystem as of the moment I think.

Thanks for asking. I'll consider this more.

@iamolegga
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants