Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resources download functionality #3

Closed
naruaika opened this issue Mar 2, 2021 · 4 comments · Fixed by #9
Closed

Resources download functionality #3

naruaika opened this issue Mar 2, 2021 · 4 comments · Fixed by #9
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@naruaika
Copy link
Owner

naruaika commented Mar 2, 2021

I guess it's better to have this functionality. This is including downloading pages, translations, tafseers, and recitations. So, instead of put them all in this repository or others, we can make the app to download from the original sources when it's needed.

On the other side, it has made me think of how to re-download them if there's a new release from the upstream. Since not all original download sites features versioning to their files. This is would be specific for the translation and tafseer only.

@naruaika naruaika added good first issue Good for newcomers help wanted Extra attention is needed enhancement New feature or request and removed help wanted Extra attention is needed labels Mar 2, 2021
@naruaika
Copy link
Owner Author

naruaika commented Mar 2, 2021

Please also consider how to apply some pre-processing procedures, for pages is highly pre-processed to obtain all the bounding boxes. Thinking of doing resource-intensive pre-processing on the user side is barely good at all. I'm talking about not putting all the resources on our special repository.

@naruaika naruaika self-assigned this Mar 6, 2021
@naruaika
Copy link
Owner Author

naruaika commented Mar 6, 2021

Since we are using translations from Tanzil.net, please read the terms and use. In my understanding, the following quote is clear that we are not allowed to redistribute it to our repositories:

Redistributing the following list in another website is not allowed, unless direct permission is granted by the Tanzil Project.

So, pre-processing on the user side can not be avoided.

By the way, we need to put a link back somewhere (maybe in the about dialog?) to http://tanzil.net/trans/ as we're going to use more than three of their translations.

@naruaika
Copy link
Owner Author

naruaika commented Mar 6, 2021

Please also consider how to apply some pre-processing procedures, for pages is highly pre-processed to obtain all the bounding boxes. Thinking of doing resource-intensive pre-processing on the user side is barely good at all. I'm talking about not putting all the resources on our special repository.

I was thinking if we want to implement a scrapping to watch the translation log at Tanzil.net to re-download the resource once updated. Is it safe and legal? I won't think if we need to regularly re-download then extract the update at information from it, despite having small sizes (around 1 MB) ...

@naruaika naruaika linked a pull request Mar 6, 2021 that will close this issue
@naruaika naruaika removed a link to a pull request Mar 6, 2021
@naruaika
Copy link
Owner Author

naruaika commented Mar 6, 2021

Is there any good reason to include resource removal functionality?

@naruaika naruaika linked a pull request Mar 7, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant