Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF: scheme adminep daemons leak psm memory on stop #3

Open
iondev33 opened this issue Dec 20, 2023 · 0 comments
Open

SF: scheme adminep daemons leak psm memory on stop #3

iondev33 opened this issue Dec 20, 2023 · 0 comments
Assignees
Labels
Source Forge - bug bug report migrated from SF
Milestone

Comments

@iondev33
Copy link
Collaborator

The function stopScheme uses the function sm_TaskKill(vscheme->admAppPid, SIGTERM). The issue with this is that this doesn't give the scheme's adminep daemon the chance to properly shutdown (such as closing the BpSAP for the admin eid and releasing any buffers it may have allocated).

My suggestion is to instead send a SIGINT to the admAppPid, and then have the adminep daemon responsible for handling the SIGINT. The stopScheme function should then wait until the task no longer exists, or until a set timeout is reached where it can then send the SIGTERM (in case the adminep daemon is stuck).

------ comment --------
Actually, the handleAdminBundles function does correctly handle the SIGTERM signal, ending the BpSAP recvSemaphore. However, handleAdminBundles doesn't close the BpSAP on exit.

@iondev33 iondev33 added the Source Forge - bug bug report migrated from SF label Dec 20, 2023
@iondev33 iondev33 added this to the ION 4.1.4 milestone Dec 20, 2023
@iondev33 iondev33 self-assigned this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source Forge - bug bug report migrated from SF
Projects
None yet
Development

No branches or pull requests

1 participant