Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SF: CGR Code Query from lch316@users.sourceforge.net #6

Open
iondev33 opened this issue Dec 20, 2023 · 0 comments
Open

SF: CGR Code Query from lch316@users.sourceforge.net #6

iondev33 opened this issue Dec 20, 2023 · 0 comments
Assignees
Labels
Source Forge - bug bug report migrated from SF
Milestone

Comments

@iondev33
Copy link
Collaborator

The position "route ->toNodeNbr=contact ->toNode; route ->fromTime=contact ->fromTime;" in line 1166 and 1167 of "\ION package\ion-open-source-4.1.1\bpv6\cgr\libcgr.c" , I think we should change "route" to "newRoute" here. I'd like to know your opinion.

-------- comment by John Huff -----------
Yes, my understanding is that it should be newRoute. newRoute was correctly having toNodeNbr and fromTime set in computeRoute, making this bug harder to detect. Computing a spur route shouldn't have any effect on the route used to compute it

@iondev33 iondev33 added the Source Forge - bug bug report migrated from SF label Dec 20, 2023
@iondev33 iondev33 added this to the ION 4.1.4 milestone Dec 20, 2023
@iondev33 iondev33 self-assigned this Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Source Forge - bug bug report migrated from SF
Projects
None yet
Development

No branches or pull requests

1 participant