Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastcat cannot start with the automatically generated fastcat_saved_positions.yaml when there are no actuators #45

Closed
d-loret opened this issue Aug 4, 2022 · 1 comment · Fixed by #50
Assignees
Labels
bug Something isn't working

Comments

@d-loret
Copy link
Contributor

d-loret commented Aug 4, 2022

Fastcat has issues starting up an EtherCAT networks without actuators if a fastcat_saved_positions.yaml is generated automatically.
Without actuators in the topology and actuator_fault_on_missing_pos_file set to False, Fastcat can be brought up the first time. An empty fastcat_saved_positions.yaml is created at the end.

When Fastcat is attempted to be brought up a second time, the following error occurs:

08/04/22 16:38:04 (1659656284.394366) [DEBUG]                     manager.cc:837 | Opening Pos File: /cal//fastcat_saved_positions.yaml
08/04/22 16:38:04 (1659656284.394389) [ERROR]                 yaml_parser.cc:12  | Expecting YAML Node: actuators
terminate called after throwing an instance of 'std::invalid_argument'
  what():  Fastcat Manager failed to process bus configuration YAML file.

To start up Fastcat again requires to manually delete the created fastcat_saved_positions.yaml or adding an actuators: line to the file.

When there are no actuators in the topology, Fastcat should 1) appropriately handle an empty fastcat_saved_positions.yaml without faulting, or 2) add an actuators: line to fastcat_saved_positions.yaml when it creates the file automatically.

@d-loret
Copy link
Contributor Author

d-loret commented Aug 4, 2022

Seems that we need more logic around here: https://github.com/nasa-jpl/fastcat/blob/master/src/manager.cc#L831-L834

@d-loret d-loret changed the title Fastcat cannot start with the automatically generated fastcat_saved_positions.yaml Fastcat cannot start with the automatically generated fastcat_saved_positions.yaml when there are no actuators Aug 4, 2022
@alex-brinkman alex-brinkman added the bug Something isn't working label Sep 22, 2022
@alex-brinkman alex-brinkman self-assigned this Sep 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants