Fix #29, Fix #14, update code coverage, #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skliper
requested changes
Jul 5, 2022
unit-test/ds_cmds_tests.c
Outdated
Comment on lines
3034
to
3035
| int32 strCmpResult; | ||
| char ExpectedEventString[CFE_MISSION_EVS_MAX_MESSAGE_LENGTH]; |
There was a problem hiding this comment.
Remove (along with noted sections below). Checking a constant event string adds very little value. Checking the Event ID is sufficient and easier to maintain.
unit-test/ds_cmds_tests.c
Outdated
| size_t forced_Size = sizeof(DS_CloseAllCmd_t); | ||
|
|
||
| UT_SetDataBuffer(UT_KEY(CFE_MSG_GetSize), &forced_Size, sizeof(forced_Size), false); | ||
| snprintf(ExpectedEventString, CFE_MISSION_EVS_MAX_MESSAGE_LENGTH, "DEST CLOSE ALL command"); |
unit-test/ds_cmds_tests.c
Outdated
Comment on lines
3057
to
3058
| strCmpResult = strncmp(ExpectedEventString, context_CFE_EVS_SendEvent[0].Spec, CFE_MISSION_EVS_MAX_MESSAGE_LENGTH); | ||
| UtAssert_True(strCmpResult == 0, "Event string matched expected result, '%s'", context_CFE_EVS_SendEvent[0].Spec); |
unit-test/ds_cmds_tests.c
Outdated
| UtAssert_True(strCmpResult == 0, "Event string matched expected result, '%s'", context_CFE_EVS_SendEvent[0].Spec); | ||
|
|
||
| /* Verify command struct size minus header is at least explicitly padded to 32-bit boundaries */ | ||
| UtAssert_True(CMD_STRUCT_DATA_IS_32_ALIGNED(DS_CloseAllCmd_t), "DS_CloseAllCmd_t is 32-bit aligned"); |
There was a problem hiding this comment.
Avoid ever using UtAssert_True. UtAssert_BOOL_TRUE is the preferred macro.
unit-test/ds_file_tests.c
Outdated
Comment on lines
1434
to
1437
| UtAssert_True(DS_AppData.FileStatus[FileIndex].FileAge == 0, "DS_AppData.FileStatus[FileIndex].FileAge == 0"); | ||
| UtAssert_True(DS_AppData.FileStatus[FileIndex].FileSize == 0, "DS_AppData.FileStatus[FileIndex].FileSize == 0"); | ||
| UtAssert_True(DS_AppData.FileStatus[FileIndex].FileName[0] == 0, | ||
| "DS_AppData.FileStatus[FileIndex].FileName[0] == 0"); |
There was a problem hiding this comment.
These could be UtAssert_UINT32_EQ
Removes comments about DS_AppProcessHK_Test_SnprintfFail, Adds DS_CmdCloseAll_Test_CloseAll, Adds coverage of null filename with no "/" to DS_FileCloseDest Adds coverage of !OS_ObjectDefined 2nd check in DS_FileSetupWrite() Adds coverage of StringTerminator branch in DS_FileCreateDest_Test() Adds coverage of MaxPathnameLength branch in DS_FileCreatName_Test() Adds PathBaseSeqTooLarge in DS_FileCreatName_Test() Adds PathBaseSeqExtTooLarge in DS_FileCreatName_Test() Adds ExtensionZero in DS_FileCreatName_Test() Adds UtAssert fixes according to PR review
skliper
approved these changes
Jul 5, 2022
chillfig
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes comments about DS_AppProcessHK_Test_SnprintfFail,
Adds DS_CmdCloseAll_Test_CloseAll,
Adds coverage of null filename with no "/" to DS_FileCloseDest
Adds coverage of !OS_ObjectDefined 2nd check in DS_FileSetupWrite()
Adds coverage of StringTerminator branch in DS_FileCreateDest_Test()
Adds coverage of MaxPathnameLength branch in DS_FileCreatName_Test()
Adds PathBaseSeqTooLarge in DS_FileCreatName_Test()
Adds PathBaseSeqExtTooLarge in DS_FileCreatName_Test()
Adds ExtensionZero in DS_FileCreatName_Test()
Checklist (Please check before submitting)
Describe the contribution
A clear and concise description of what the contribution is.
Testing performed
Expected behavior changes
100% code coverage
System(s) tested on
Ubuntu 18.04
Additional context
100% coverage depends on the resolution of #32
Afterwards, .github/workflows/unit-test-coverage.yml will need to be updated in this pull request to account for no missing branch coverage.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Justin Figueroa, ASRC Federal