Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Header guard update to match osal pattern #1239

Closed
skliper opened this issue Mar 17, 2021 · 0 comments · Fixed by #1258
Closed

Header guard update to match osal pattern #1239

skliper opened this issue Mar 17, 2021 · 0 comments · Fixed by #1258
Assignees
@jphickey
Labels
enhancement
Milestone
Caelum

Comments

@skliper
Copy link
Contributor

skliper commented Mar 17, 2021

Is your feature request related to a problem? Please describe.
Current header guards utilized reserved leading _, likely also inconsistent

Helpful if it also catches endif comment (typically comments the matching define)

Describe the solution you'd like
Apply OSAL pattern

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC
jphickey added a commit to jphickey/cFE that referenced this issue Mar 24, 2021
@jphickey
Fix nasa#1239, scrub include header guards
3ab6a53 
All C header files should have a header guard matching the file
name of the header, in ALL_CAPS, with no extra leading/trailing
underscores.

This also takes a first pass at converting the file-scope block
comments to a doxygen format to include a summary of the file.
@jphickey jphickey mentioned this issue Mar 24, 2021
Merged
jphickey added a commit to jphickey/cFE that referenced this issue Mar 24, 2021
@jphickey
Fix nasa#1239, apply "uniq" filer to files
0780d12 
This removes cases where extra blank lines in comments were present.

This affects both the newly added blocks as well as some existing
cases where extra blank lines were inside block comments.
@astrogeco astrogeco mentioned this issue Mar 25, 2021
Merged
astrogeco added a commit that referenced this issue Mar 25, 2021
@astrogeco
Merge pull request #1262 from jphickey/fix-1239-header-guards
0cea6e6 
Fix #1239, scrub include header guards
@skliper skliper added this to the 7.0.0 milestone Sep 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jphickey jphickey

Labels
enhancement
Projects
None yet
Milestone
Caelum
Development

Successfully merging a pull request may close this issue.

cFE Integration candidate: 2021-03-30 nasa/cFE
2 participants
@jphickey @skliper