We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Is your feature request related to a problem? Please describe. Defines are both discouraged by standards and clumsy when type matters.
Describe the solution you'd like Convert to constant variables, performance is maintained and get type checking.
Use has started but should really convert the existing defines, example:
cFE/modules/fs/fsw/src/cfe_fs_api.c
Lines 45 to 48 in 73c338d
Example of improvements, filters as const variables would allow overflow checking:
cFE/modules/core_api/fsw/inc/cfe_evs_api_typedefs.h
Lines 42 to 55 in c8b5e00
Describe alternatives you've considered None.
Additional context Code review
Requester Info Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered:
No branches or pull requests
Is your feature request related to a problem? Please describe.
Defines are both discouraged by standards and clumsy when type matters.
Describe the solution you'd like
Convert to constant variables, performance is maintained and get type checking.
Use has started but should really convert the existing defines, example:
cFE/modules/fs/fsw/src/cfe_fs_api.c
Lines 45 to 48 in 73c338d
Example of improvements, filters as const variables would allow overflow checking:
cFE/modules/core_api/fsw/inc/cfe_evs_api_typedefs.h
Lines 42 to 55 in c8b5e00
Describe alternatives you've considered
None.
Additional context
Code review
Requester Info
Jacob Hageman - NASA/GSFC
The text was updated successfully, but these errors were encountered: