Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1985, Check return value of CFE_ES_PutPoolBuf #2235

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Dec 29, 2022

Checklist

Describe the contribution

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
In case of error, the relevant details will be written to the log.

Alternative considered
Simpler version:
Screenshot 2022-12-30 08 10 47

Contributor Info
Avi Weiss @thnkslprpt


if (Status < 0)
{
CFE_ES_WriteToSysLog("%s: PutPoolBuf Fail Stat=0x%08X, Hndl=0x%08lX, Buf=0x%08lX\n", __func__,
Copy link
Contributor

@skliper skliper Jan 3, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider only writing once to avoid flooding the log. Might be one of the errors that would be helpful to track w/ something in HK, as a system health indicator. See #1469.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jake @skliper, how would I go about limiting it to one write?
Cheers

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relates to:

It's a bigger conceptual change, but I'm a big fan of persistent indication of system health/issues of this flavor. So if there was a bitfield/counter or similar in HK to track these sort of issues, you could only print if there wasn't a previous failure of this type indicated.

@thnkslprpt thnkslprpt force-pushed the fix-1985-check-putpoolbuf-return branch from 64e05c4 to 292e018 Compare April 19, 2024 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Return Value of CFE_ES_PutPoolBuf
2 participants