Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1684, Add functional tests for cFE SB Message ID APIs #2304

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Apr 25, 2023

Checklist

Describe the contribution

  • Fixes Add functional tests for cFE Message ID APIs #1684
    • Added functional tests for CFE_SB_IsValidMsgId(), CFE_SB_MsgId_Equal(), CFE_SB_MsgIdToValue() and CFE_SB_ValueToMsgId().
    • renamed message_id_test.c to msg_msg_id_test.c to avoid confusion and better differentiate it from the new test file for the SB MsgId tests created in this PR
    • couple text improvements and removal of trailing whitespace piggy-backing on this PR

Testing performed
GitHub CI actions all passing successfully.

Expected behavior changes
Test code changes only.

Contributor Info
Avi Weiss @thnkslprpt

*/
#include "cfe_test.h"

void TestCheckIfValidMsgId(void)

Check notice

Code scanning / CodeQL

Long function without assertion Note test

All functions of more than 10 lines should have at least one assertion.
UtAssert_True(Result == false, "Result == false");
}

void TestCheckIfMsgIdEqual(void)

Check notice

Code scanning / CodeQL

Long function without assertion Note test

All functions of more than 10 lines should have at least one assertion.
@thnkslprpt thnkslprpt force-pushed the fix-1684-add-functional-tests-for-SB-MsgId-APIs branch from 7b38a40 to f957e83 Compare April 25, 2023 01:37
@thnkslprpt thnkslprpt force-pushed the fix-1684-add-functional-tests-for-SB-MsgId-APIs branch 2 times, most recently from 1991a60 to bbef319 Compare May 6, 2023 12:18
@thnkslprpt thnkslprpt force-pushed the fix-1684-add-functional-tests-for-SB-MsgId-APIs branch from bbef319 to a2d35fa Compare September 5, 2023 02:50
@thnkslprpt thnkslprpt force-pushed the fix-1684-add-functional-tests-for-SB-MsgId-APIs branch from a2d35fa to 37b1b16 Compare March 23, 2024 02:34
@thnkslprpt thnkslprpt force-pushed the fix-1684-add-functional-tests-for-SB-MsgId-APIs branch from 37b1b16 to 91f2837 Compare April 20, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add functional tests for cFE Message ID APIs
1 participant