You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Previously, each table ".c" source file was built into its own static library target based on that source file name. This had the side effect of creating lots of complexly-named static lib targets.
With recent changes, this is changed to build all listed table source files listed into a single, simpler-named target.
Now a new problem occurs if one tries to build table files separately. For example, something like this:
Will both try to register a static lib target named tblobj_cpu1_sc, which results in a target name collision error.
Describe the solution you'd like
Invoking add_cfe_tables as above should work without a target name collision.
Describe alternatives you've considered
The add_cfe_tables does allow for a name suffix, which is used as part of the lib name - so as long as that suffix is unique, there is no name collision. For example, this works:
It is only the case of multiple invocations of add_cfe_tables with the same first parameter that triggers this conflict.
Additional context
Unfortunately, we had previously documented/recommended the first parameter of add_cfe_tables to match the app name, so there may be more users that were following the problematic pattern above (1 is confirmed).
Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered:
jphickey
added a commit
to jphickey/cFE
that referenced
this issue
May 2, 2023
If the passed-in table name does not use a qualifier suffix, then
generate one by computing a hash of the context information. This
ensures that the generated intermediate target names will be unique.
Is your feature request related to a problem? Please describe.
Previously, each table ".c" source file was built into its own static library target based on that source file name. This had the side effect of creating lots of complexly-named static lib targets.
With recent changes, this is changed to build all listed table source files listed into a single, simpler-named target.
Now a new problem occurs if one tries to build table files separately. For example, something like this:
Will both try to register a static lib target named
tblobj_cpu1_sc
, which results in a target name collision error.Describe the solution you'd like
Invoking
add_cfe_tables
as above should work without a target name collision.Describe alternatives you've considered
The
add_cfe_tables
does allow for a name suffix, which is used as part of the lib name - so as long as that suffix is unique, there is no name collision. For example, this works:And listing mutiple source files works too:
It is only the case of multiple invocations of
add_cfe_tables
with the same first parameter that triggers this conflict.Additional context
Unfortunately, we had previously documented/recommended the first parameter of
add_cfe_tables
to match the app name, so there may be more users that were following the problematic pattern above (1 is confirmed).Requester Info
Joseph Hickey, Vantage Systems, Inc.
The text was updated successfully, but these errors were encountered: