Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix#2388, Revert "Merge pull request #2356 from CDKnightNASA/fix-2316-time_fmt" #2389

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Fix#2388, Revert "Merge pull request #2356 from CDKnightNASA/fix-2316-time_fmt" #2389

merged 1 commit into from
Jun 26, 2023

Conversation

dzbaker
Copy link
Collaborator

@dzbaker dzbaker commented Jun 26, 2023

Checklist (Please check before submitting)

Describe the contribution
Reverts #2356

Testing performed
N/A

Expected behavior changes
#2315 is removed.

System(s) tested on
N/A

Contributor Info - All information REQUIRED for consideration of pull request
Dylan Z. Baker - NASA GSFC

@dzbaker
Fix#2388, Revert "Merge pull request #2356 from CDKnightNASA/fix-2316…
a682f18 
…-time_fmt"

This reverts commit 7c27c0e, reversing
changes made to b5b90b4.
github-advanced-security[bot]
github-advanced-security bot found potential problems Jun 26, 2023
View reviewed changes
modules/time/fsw/src/cfe_time_api.c
@@ -565,30 +563,150 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
CFE_Status_t CFE_TIME_Print(char *PrintBuffer, CFE_TIME_SysTime_t TimeToPrint)
void CFE_TIME_Print(char *PrintBuffer, CFE_TIME_SysTime_t TimeToPrint)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
modules/time/fsw/src/cfe_time_api.c
@@ -565,30 +563,150 @@
* See description in header file for argument/return detail
*
*-----------------------------------------------------------------*/
CFE_Status_t CFE_TIME_Print(char *PrintBuffer, CFE_TIME_SysTime_t TimeToPrint)
void CFE_TIME_Print(char *PrintBuffer, CFE_TIME_SysTime_t TimeToPrint)

Check notice

Code scanning / CodeQL

Function too long

CFE_TIME_Print has too many lines (145, while 60 are allowed).
modules/time/fsw/src/cfe_time_api.c

if (PrintBuffer == NULL)
{
return CFE_TIME_BAD_ARGUMENT;
CFE_ES_WriteToSysLog("%s: Failed invalid arguments\n", __func__);

Check warning

Code scanning / CodeQL

Uses of recursion

The function CFE_TIME_Print is indirectly recursive via this call to [CFE_ES_WriteToSysLog](1).
modules/core_api/ut-stubs/src/cfe_time_stubs.c
@@ -305,16 +305,12 @@
* Generated stub function for CFE_TIME_Print()
* ----------------------------------------------------
*/
CFE_Status_t CFE_TIME_Print(char *PrintBuffer, CFE_TIME_SysTime_t TimeToPrint)
void CFE_TIME_Print(char *PrintBuffer, CFE_TIME_SysTime_t TimeToPrint)

Check notice

Code scanning / CodeQL

Long function without assertion

All functions of more than 10 lines should have at least one assertion.
modules/core_api/ut-stubs/src/cfe_time_stubs.c
@@ -305,16 +305,12 @@
* Generated stub function for CFE_TIME_Print()
* ----------------------------------------------------
*/
CFE_Status_t CFE_TIME_Print(char *PrintBuffer, CFE_TIME_SysTime_t TimeToPrint)
void CFE_TIME_Print(char *PrintBuffer, CFE_TIME_SysTime_t TimeToPrint)

Check notice

Code scanning / CodeQL

Function too long

CFE_TIME_Print has too many lines (145, while 60 are allowed).
@dzbaker dzbaker added CCB:Ready Ready for discussion at the Configuration Control Board (CCB) CCB:FastTrack labels Jun 26, 2023
@dzbaker dzbaker merged commit 600a209 into main Jun 26, 2023
@dzbaker dzbaker mentioned this pull request Jul 11, 2023
Open
2 tasks
@dmknutsen dmknutsen added this to the Equuleus milestone Aug 3, 2023
@jphickey jphickey deleted the Fix2388 branch January 17, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CCB:FastTrack CCB:Ready Ready for discussion at the Configuration Control Board (CCB) Equuleus-rc1
Projects
None yet
Milestone
Equuleus
Development

Successfully merging this pull request may close these issues.

Push off PR #2356 to Equuleus-rc2
2 participants
@dzbaker @dmknutsen