cFE Integration candidate: 2021-04-27

[astrogeco]

Description

PR #1379

Fix #1317, memory pool pointer type

No behavior changes. Changes the type of pointer for MemPtr in CFE_ES_PoolCreateNoSem API from uint8* to void* to be more consistent and easier to use. Should be backward compatible.
Updates the doxygen documentation for this parameter, as it was incorrectly specifying a 32-bit alignment requirement.

PR #1289

Fix #809, ES child task functional test

Fixes #1291, typo in macro name

Adds new functional tests for ES Child Task API. Does not check edge cases. Fixed spelling mistake in UtAssert_ResourceID_Undifeined name

PR #1286

Fix #1285, Remove broken BUILDDIR reference

Removes BUILDDIR reference and an old comment. No behavior changes

PR #1305

Fix #1301, remove option for "osal_compatible"

Moves and renames cfe_resourceid_basevalue.h to cfe_resourceid_basevalue.h. Since it is is assumed/required that resource IDs follow the "osal compatible" pattern. Perhaps in a future version this could change, but

PR #1374

Fix #1311, CFE_SUCCESS constant type

Ensures that the CFE_SUCCESS constant is of the CFE_Status_t type. Since an explicit cast is required on all error codes that are expected to be negative values. No behavior change.

PR #1316

Fix #1314, Remove Unused Error Codes

Removes unused error codes: CFE_ES_ERR_SHELL_CMD and CFE_SB_NO_MSG_RECV. No impact to behavior.

PR #1370

Fix #1330, better warning about malformed startup line

When a startup file has a line with too many tokens the build script will generate a concise warning including an indicator of which line is causing the problem.

PR #1373

Fix #1338, check status of call to CFE_ES_CDS_CachePreload

Confirm that the call to CFE_ES_CDS_CachePreload returns CFE_SUCCESS before continuing. No behavior changes. Now shows up as untested lines in the coverage report since error condition cannot be exercised through coverage.

PR #1384

Fix #1340, update documentation for CFE_ES_DeleteCDS

[docs] Clarify that CFE_ES_DeleteCDS does not wipe or erase the block, it only returns resources to the pool for re-use.

PR #1385

Fix #1345, exception logic when app/task is not found

[docs] Adds comments in CFE_ES_RunExceptionScan describing the logic when an exception cannot be traced back to a specific app, in that it should fall back to the PSP reset.

PR #1372

Fix #1346, error if alignment size not a power of two

CFE_ES_GenPoolInitialize now returns CFE_ES_BAD_ARGUMENT error if the AlignSize passed-in value is not actually a power of two instead of "fixing" the alignment mask,

PR #1368

Fix #1349, remove unneeded CFE_ES_SYSLOG_APPEND macro

Replace internal CFE_ES_SYSLOG_APPEND macro with the CFE_ES_WriteToSysLog() API since coding standards discourage use of multi-line macros. No behavior change

PR #1382

Fix #1355, improve documentation for resourceID patterns

[docs] Improve Resource IDs documentation. Specifically on use of the various helper functions and common patterns Documents that the "IsMatch()" functions accept NULL pointers so they can be used with initial validation (gatekeeper). All other helper functions assume a non-NULL pointer.

PR #1371

Fix #1365, assert CFE_RESOURCEID_MAX is a bitmask

Compiler will catch if the CFE_RESOURCEID_MAX value changes in such a way that makes it not usable as a bit mask as intended. Add a compile time assert to ensure that CFE_RESOURCEID_MAX value is one less than a power of two (i.e. an LSB-justified bit mask). Notes in the comments that it serves as both a numeric limit and a mask.

Context

Part of nasa/cFS#250

Testing

cFE Tests https://github.com/nasa/cFS/pull/250/checks

cFS bundle Tests https://github.com/nasa/cFE/pull/1431/checks

Authors

@zanzaben
@jphickey
@skliper